You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "ramkrishna.s.vasudevan (Created) (JIRA)" <ji...@apache.org> on 2012/01/18 09:17:40 UTC
[jira] [Created] (HBASE-5225) Backport HBASE-3845 -data loss
because lastSeqWritten can miss memstore edits
Backport HBASE-3845 -data loss because lastSeqWritten can miss memstore edits
-----------------------------------------------------------------------------
Key: HBASE-5225
URL: https://issues.apache.org/jira/browse/HBASE-5225
Project: HBase
Issue Type: Bug
Reporter: ramkrishna.s.vasudevan
Assignee: ramkrishna.s.vasudevan
Critical defect. not merged to 0.90.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5225) Backport HBASE-3845 -data loss
because lastSeqWritten can miss memstore edits
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190474#comment-13190474 ]
ramkrishna.s.vasudevan commented on HBASE-5225:
-----------------------------------------------
Thanks for the review Ted.
Committed to 0.90 branch.
> Backport HBASE-3845 -data loss because lastSeqWritten can miss memstore edits
> -----------------------------------------------------------------------------
>
> Key: HBASE-5225
> URL: https://issues.apache.org/jira/browse/HBASE-5225
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.90.6
>
> Attachments: HBASE-3845-90.patch, HBASE-3845_0.90_1.patch
>
>
> Critical defect. Patch from HBASE-3845 was not integrated to 0.90.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5225) Backport HBASE-3845 -data loss
because lastSeqWritten can miss memstore edits
Posted by "Jieshan Bean (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jieshan Bean updated HBASE-5225:
--------------------------------
Attachment: HBASE-3845-90.patch
All unit tests passed..and also verified this patch in real cluster.
> Backport HBASE-3845 -data loss because lastSeqWritten can miss memstore edits
> -----------------------------------------------------------------------------
>
> Key: HBASE-5225
> URL: https://issues.apache.org/jira/browse/HBASE-5225
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.90.6
>
> Attachments: HBASE-3845-90.patch
>
>
> Critical defect. not merged to 0.90.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5225) Backport HBASE-3845 -data loss
because lastSeqWritten can miss memstore edits
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190467#comment-13190467 ]
Zhihong Yu commented on HBASE-5225:
-----------------------------------
+1 on patch v2.
> Backport HBASE-3845 -data loss because lastSeqWritten can miss memstore edits
> -----------------------------------------------------------------------------
>
> Key: HBASE-5225
> URL: https://issues.apache.org/jira/browse/HBASE-5225
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.90.6
>
> Attachments: HBASE-3845-90.patch, HBASE-3845_0.90_1.patch
>
>
> Critical defect. Patch from HBASE-3845 was not integrated to 0.90.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5225) Backport HBASE-3845 -data loss
because lastSeqWritten can miss memstore edits
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190333#comment-13190333 ]
ramkrishna.s.vasudevan commented on HBASE-5225:
-----------------------------------------------
Pls review. Planning to commit to 0.90 today.
> Backport HBASE-3845 -data loss because lastSeqWritten can miss memstore edits
> -----------------------------------------------------------------------------
>
> Key: HBASE-5225
> URL: https://issues.apache.org/jira/browse/HBASE-5225
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.90.6
>
> Attachments: HBASE-3845-90.patch, HBASE-3845_0.90_1.patch
>
>
> Critical defect. Patch from HBASE-3845 was not integrated to 0.90.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5225) Backport HBASE-3845 -data loss
because lastSeqWritten can miss memstore edits
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190054#comment-13190054 ]
Zhihong Yu commented on HBASE-5225:
-----------------------------------
Patch looks good.
{code}
+ * oldest in-memory edit's lsn for the region that was being flushed.
{code}
Please replace lsn above with 'log-seq-number'.
{code}
+ * lsn of the earliest in-memory lsn - which is now in the memstore snapshot -
{code}
The first part of the above sentence should read 'the earliest in-memory log-seq-number'.
{code}
+ // lastSeqWritten.putIfAbsent() in append() and we will always win
+ // before releasing cacheFlushLock make sure that the region's entry in
{code}
Please put a period after 'win' so that it is easier to read.
{code}
+ LOG.error("Logic Error region " + Bytes.toString(encodedRegionName)
+ + "acquired edits out of order current memstore seq="
{code}
A space is needed before 'acquired'.
> Backport HBASE-3845 -data loss because lastSeqWritten can miss memstore edits
> -----------------------------------------------------------------------------
>
> Key: HBASE-5225
> URL: https://issues.apache.org/jira/browse/HBASE-5225
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.90.6
>
> Attachments: HBASE-3845-90.patch
>
>
> Critical defect. Patch from HBASE-3845 was not integrated to 0.90.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5225) Backport HBASE-3845 -data loss
because lastSeqWritten can miss memstore edits
Posted by "ramkrishna.s.vasudevan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-5225:
------------------------------------------
Attachment: HBASE-3845_0.90_1.patch
Update patch addressing Ted's comments.
> Backport HBASE-3845 -data loss because lastSeqWritten can miss memstore edits
> -----------------------------------------------------------------------------
>
> Key: HBASE-5225
> URL: https://issues.apache.org/jira/browse/HBASE-5225
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.90.6
>
> Attachments: HBASE-3845-90.patch, HBASE-3845_0.90_1.patch
>
>
> Critical defect. Patch from HBASE-3845 was not integrated to 0.90.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5225) Backport HBASE-3845 -data loss
because lastSeqWritten can miss memstore edits
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5225:
------------------------------
Description: Critical defect. Patch from HBASE-3845 was not integrated to 0.90. (was: Critical defect. not merged to 0.90.)
> Backport HBASE-3845 -data loss because lastSeqWritten can miss memstore edits
> -----------------------------------------------------------------------------
>
> Key: HBASE-5225
> URL: https://issues.apache.org/jira/browse/HBASE-5225
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.90.6
>
> Attachments: HBASE-3845-90.patch
>
>
> Critical defect. Patch from HBASE-3845 was not integrated to 0.90.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5225) Backport HBASE-3845 -data loss
because lastSeqWritten can miss memstore edits
Posted by "ramkrishna.s.vasudevan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-5225:
------------------------------------------
Affects Version/s: 0.90.4
Fix Version/s: 0.90.6
> Backport HBASE-3845 -data loss because lastSeqWritten can miss memstore edits
> -----------------------------------------------------------------------------
>
> Key: HBASE-5225
> URL: https://issues.apache.org/jira/browse/HBASE-5225
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.90.6
>
>
> Critical defect. not merged to 0.90.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5225) Backport HBASE-3845 -data loss
because lastSeqWritten can miss memstore edits
Posted by "ramkrishna.s.vasudevan (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan resolved HBASE-5225.
-------------------------------------------
Resolution: Fixed
Committed to 0.90.
> Backport HBASE-3845 -data loss because lastSeqWritten can miss memstore edits
> -----------------------------------------------------------------------------
>
> Key: HBASE-5225
> URL: https://issues.apache.org/jira/browse/HBASE-5225
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.4
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.90.6
>
> Attachments: HBASE-3845-90.patch, HBASE-3845_0.90_1.patch
>
>
> Critical defect. Patch from HBASE-3845 was not integrated to 0.90.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira