You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Sam Glover <sa...@cloudera.com> on 2015/12/17 21:33:30 UTC
Re: Review Request 41529: FLUME-2858,
Add better exception message for malformed zookeeper,
also add a default of 2181 if the port is not given.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41529/
-----------------------------------------------------------
(Updated Dec. 17, 2015, 8:33 p.m.)
Review request for Flume and Ted Malaska.
Repository: flume-git
Description
-------
FLUME-2858, Added better exception message for malformed zookeeperQuorum. Added default port 2181 if the zookeeperQuorum port is not given.
Diffs
-----
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java e659ada
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java 5560624
Diff: https://reviews.apache.org/r/41529/diff/
Testing
-------
Yes. Ran mvn clean install with no issues, no failures.
Thanks,
Sam Glover
Re: Review Request 41529: FLUME-2858,
Add better exception message for malformed zookeeper,
also add a default of 2181 if the port is not given.
Posted by Sam Glover <sa...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41529/
-----------------------------------------------------------
(Updated Dec. 28, 2015, 8:29 p.m.)
Review request for Flume and Ted Malaska.
Changes
-------
patch 8 uploaded
Repository: flume-git
Description
-------
FLUME-2858, Added better exception message for malformed zookeeperQuorum. Added default port 2181 if the zookeeperQuorum port is not given.
Diffs
-----
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java e659ada
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java 5560624
Diff: https://reviews.apache.org/r/41529/diff/
Testing
-------
Yes. Ran mvn clean install with no issues, no failures.
File Attachments (updated)
----------------
patch 5
https://reviews.apache.org/media/uploaded/files/2015/12/28/1bc03ad3-6a7b-428b-993f-3a5558fc90fa__FLUME-2858-5.patch
patch 6
https://reviews.apache.org/media/uploaded/files/2015/12/28/fb74e4d9-f33c-49d0-be90-1781d6cc012c__FLUME-2858-6.patch
Update 7
https://reviews.apache.org/media/uploaded/files/2015/12/28/fb6f5245-ec9b-4bcc-8552-0ff845aabd31__FLUME-2858-7.patch
patch 8
https://reviews.apache.org/media/uploaded/files/2015/12/28/d8be578d-93b6-4e94-ba3e-aba8a473b4c5__FLUME-2858-8.patch
Thanks,
Sam Glover
Re: Review Request 41529: FLUME-2858,
Add better exception message for malformed zookeeper,
also add a default of 2181 if the port is not given.
Posted by Sam Glover <sa...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41529/
-----------------------------------------------------------
(Updated Dec. 28, 2015, 8:12 p.m.)
Review request for Flume and Ted Malaska.
Repository: flume-git
Description
-------
FLUME-2858, Added better exception message for malformed zookeeperQuorum. Added default port 2181 if the zookeeperQuorum port is not given.
Diffs (updated)
-----
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java e659ada
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java 5560624
Diff: https://reviews.apache.org/r/41529/diff/
Testing
-------
Yes. Ran mvn clean install with no issues, no failures.
File Attachments
----------------
patch 5
https://reviews.apache.org/media/uploaded/files/2015/12/28/1bc03ad3-6a7b-428b-993f-3a5558fc90fa__FLUME-2858-5.patch
patch 6
https://reviews.apache.org/media/uploaded/files/2015/12/28/fb74e4d9-f33c-49d0-be90-1781d6cc012c__FLUME-2858-6.patch
Update 7
https://reviews.apache.org/media/uploaded/files/2015/12/28/fb6f5245-ec9b-4bcc-8552-0ff845aabd31__FLUME-2858-7.patch
Thanks,
Sam Glover
Re: Review Request 41529: FLUME-2858,
Add better exception message for malformed zookeeper,
also add a default of 2181 if the port is not given.
Posted by Sam Glover <sa...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41529/
-----------------------------------------------------------
(Updated Dec. 28, 2015, 8:11 p.m.)
Review request for Flume and Ted Malaska.
Changes
-------
Patch 7 attached. Corrected syntax after testing.
Repository: flume-git
Description
-------
FLUME-2858, Added better exception message for malformed zookeeperQuorum. Added default port 2181 if the zookeeperQuorum port is not given.
Diffs
-----
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java e659ada
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java 5560624
Diff: https://reviews.apache.org/r/41529/diff/
Testing
-------
Yes. Ran mvn clean install with no issues, no failures.
File Attachments (updated)
----------------
patch 5
https://reviews.apache.org/media/uploaded/files/2015/12/28/1bc03ad3-6a7b-428b-993f-3a5558fc90fa__FLUME-2858-5.patch
patch 6
https://reviews.apache.org/media/uploaded/files/2015/12/28/fb74e4d9-f33c-49d0-be90-1781d6cc012c__FLUME-2858-6.patch
Update 7
https://reviews.apache.org/media/uploaded/files/2015/12/28/fb6f5245-ec9b-4bcc-8552-0ff845aabd31__FLUME-2858-7.patch
Thanks,
Sam Glover
Re: Review Request 41529: FLUME-2858,
Add better exception message for malformed zookeeper,
also add a default of 2181 if the port is not given.
Posted by Sam Glover <sa...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41529/
-----------------------------------------------------------
(Updated Dec. 28, 2015, 6:35 p.m.)
Review request for Flume and Ted Malaska.
Changes
-------
Patch 6 to resolve a syntax issue.
Repository: flume-git
Description
-------
FLUME-2858, Added better exception message for malformed zookeeperQuorum. Added default port 2181 if the zookeeperQuorum port is not given.
Diffs (updated)
-----
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java e659ada
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java 5560624
Diff: https://reviews.apache.org/r/41529/diff/
Testing
-------
Yes. Ran mvn clean install with no issues, no failures.
File Attachments (updated)
----------------
patch 5
https://reviews.apache.org/media/uploaded/files/2015/12/28/1bc03ad3-6a7b-428b-993f-3a5558fc90fa__FLUME-2858-5.patch
patch 6
https://reviews.apache.org/media/uploaded/files/2015/12/28/fb74e4d9-f33c-49d0-be90-1781d6cc012c__FLUME-2858-6.patch
Thanks,
Sam Glover
Re: Review Request 41529: FLUME-2858,
Add better exception message for malformed zookeeper,
also add a default of 2181 if the port is not given.
Posted by Sam Glover <sa...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41529/
-----------------------------------------------------------
(Updated Dec. 28, 2015, 6:26 p.m.)
Review request for Flume and Ted Malaska.
Changes
-------
Corrected logic in HBaseSink.java
Repository: flume-git
Description
-------
FLUME-2858, Added better exception message for malformed zookeeperQuorum. Added default port 2181 if the zookeeperQuorum port is not given.
Diffs
-----
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java e659ada
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java 5560624
Diff: https://reviews.apache.org/r/41529/diff/
Testing
-------
Yes. Ran mvn clean install with no issues, no failures.
File Attachments (updated)
----------------
patch 5
https://reviews.apache.org/media/uploaded/files/2015/12/28/1bc03ad3-6a7b-428b-993f-3a5558fc90fa__FLUME-2858-5.patch
Thanks,
Sam Glover
Re: Review Request 41529: FLUME-2858,
Add better exception message for malformed zookeeper,
also add a default of 2181 if the port is not given.
Posted by Sam Glover <sa...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41529/
-----------------------------------------------------------
(Updated Dec. 19, 2015, 1:31 p.m.)
Review request for Flume and Ted Malaska.
Changes
-------
Added try / catch logic and resolved all compile, test issues when running "mvn clean install".
Repository: flume-git
Description
-------
FLUME-2858, Added better exception message for malformed zookeeperQuorum. Added default port 2181 if the zookeeperQuorum port is not given.
Diffs (updated)
-----
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java e659ada
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java 5560624
Diff: https://reviews.apache.org/r/41529/diff/
Testing
-------
Yes. Ran mvn clean install with no issues, no failures.
Thanks,
Sam Glover
Re: Review Request 41529: FLUME-2858,
Add better exception message for malformed zookeeper,
also add a default of 2181 if the port is not given.
Posted by Sam Glover <sa...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41529/
-----------------------------------------------------------
(Updated Dec. 18, 2015, 8:46 p.m.)
Review request for Flume and Ted Malaska.
Changes
-------
Flume-2858-3.patch updated.
Repository: flume-git
Description
-------
FLUME-2858, Added better exception message for malformed zookeeperQuorum. Added default port 2181 if the zookeeperQuorum port is not given.
Diffs (updated)
-----
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java e659ada
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java 5560624
Diff: https://reviews.apache.org/r/41529/diff/
Testing
-------
Yes. Ran mvn clean install with no issues, no failures.
Thanks,
Sam Glover
Re: Review Request 41529: FLUME-2858,
Add better exception message for malformed zookeeper,
also add a default of 2181 if the port is not given.
Posted by Ted Malaska <te...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41529/#review111044
-----------------------------------------------------------
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java (line 267)
<https://reviews.apache.org/r/41529/#comment171035>
the comment isn't needed
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java (line 302)
<https://reviews.apache.org/r/41529/#comment171036>
There should be a array size check at line 282.
Also we don't want to check for 2181. ZooKeeper may have different ports because it can be configured to anything.
What we want to do is if the array on line 282 is length 0 then on like 293 we want to set it to 2181.
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java (line 309)
<https://reviews.apache.org/r/41529/#comment171040>
We need to suround the whole parsing block with a try catch block that says. Malformed zkQuorum value.
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java (line 77)
<https://reviews.apache.org/r/41529/#comment171039>
Don't need this comment
- Ted Malaska
On Dec. 17, 2015, 8:33 p.m., Sam Glover wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41529/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 8:33 p.m.)
>
>
> Review request for Flume and Ted Malaska.
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> FLUME-2858, Added better exception message for malformed zookeeperQuorum. Added default port 2181 if the zookeeperQuorum port is not given.
>
>
> Diffs
> -----
>
> flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java e659ada
> flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java 5560624
>
> Diff: https://reviews.apache.org/r/41529/diff/
>
>
> Testing
> -------
>
> Yes. Ran mvn clean install with no issues, no failures.
>
>
> Thanks,
>
> Sam Glover
>
>