You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Virag Kothari <vi...@yahoo-inc.com> on 2013/03/11 23:09:31 UTC

Review Request: OOZIE-1261: Registered push dependencies are not removed on Coord Kill command

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9857/
-----------------------------------------------------------

Review request for oozie.


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1261


This addresses bug OOZIE-1261.
    https://issues.apache.org/jira/browse/OOZIE-1261


Diffs
-----

  trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1455309 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1455309 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1455309 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java 1455309 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 1455309 

Diff: https://reviews.apache.org/r/9857/diff/


Testing
-------


Thanks,

Virag Kothari


Re: Review Request: OOZIE-1261: Registered push dependencies are not removed on Coord Kill command

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9857/#review17704
-----------------------------------------------------------

Ship it!


Ship It!


trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java
<https://reviews.apache.org/r/9857/#comment37586>

    super.setupservicesforhcatalog



trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java
<https://reviews.apache.org/r/9857/#comment37585>

    Do we need 5 seconds?


- Rohini Palaniswamy


On March 11, 2013, 10:09 p.m., Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9857/
> -----------------------------------------------------------
> 
> (Updated March 11, 2013, 10:09 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1261
> 
> 
> This addresses bug OOZIE-1261.
>     https://issues.apache.org/jira/browse/OOZIE-1261
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1455309 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1455309 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1455309 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java 1455309 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 1455309 
> 
> Diff: https://reviews.apache.org/r/9857/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Virag Kothari
> 
>


Re: Review Request: OOZIE-1261: Registered push dependencies are not removed on Coord Kill command

Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9857/#review17707
-----------------------------------------------------------

Ship it!


Ship It!

- Mona Chitnis


On March 11, 2013, 11:30 p.m., Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9857/
> -----------------------------------------------------------
> 
> (Updated March 11, 2013, 11:30 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1261
> 
> 
> This addresses bug OOZIE-1261.
>     https://issues.apache.org/jira/browse/OOZIE-1261
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1455309 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1455309 
>   trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1455309 
>   trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java 1455309 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 1455309 
> 
> Diff: https://reviews.apache.org/r/9857/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Virag Kothari
> 
>


Re: Review Request: OOZIE-1261: Registered push dependencies are not removed on Coord Kill command

Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9857/
-----------------------------------------------------------

(Updated March 11, 2013, 11:30 p.m.)


Review request for oozie.


Changes
-------

Addressed Rohini's comments


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1261


This addresses bug OOZIE-1261.
    https://issues.apache.org/jira/browse/OOZIE-1261


Diffs (updated)
-----

  trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1455309 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordKillXCommand.java 1455309 
  trunk/core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java 1455309 
  trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsNotCompletedJPAExecutor.java 1455309 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 1455309 

Diff: https://reviews.apache.org/r/9857/diff/


Testing
-------


Thanks,

Virag Kothari