You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/10/19 07:46:59 UTC

[GitHub] [ignite] Berkof commented on a change in pull request #9441: IGNITE-14358 GridSubqueryJoinOptimizer fixes and tests.

Berkof commented on a change in pull request #9441:
URL: https://github.com/apache/ignite/pull/9441#discussion_r731584440



##########
File path: modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/GridSubqueryJoinOptimizer.java
##########
@@ -383,11 +395,20 @@ private static boolean pullOutSubQryFromTableList(
         else
             target.child(childInd, subTbl);
 
-        if (subSel.where() != null)
-            parent.where(parent.where() == null ? subSel.where() : new GridSqlOperation(AND, parent.where(), subSel.where()));
+        GridSqlAst where = subSel.where();
+        if (where != null) {

Review comment:
       Empty line before if.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org