[GitHub] [incubator-pinot] chenboat commented on a change in pull request #6286: Adding offline dimension table creation and segment assignment

[GitBox <gi...@apache.org>]

chenboat commented on a change in pull request #6286:
URL: https://github.com/apache/incubator-pinot/pull/6286#discussion_r530122778



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/OfflineSegmentAssignment.java
##########
@@ -133,6 +135,10 @@ private void checkReplication(InstancePartitions instancePartitions) {
   private List<String> assignSegment(String segmentName, Map<String, Map<String, String>> currentAssignment,
       InstancePartitions instancePartitions) {
     int numReplicaGroups = instancePartitions.getNumReplicaGroups();
+    if (_isDimTable) {

Review comment:
       can we add a new subclass of OfflineSegmentAssignment instead of using a boolean check?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org