You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/06/27 15:05:15 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #3557: HDDS-6946. Bump Hadoop to 3.3.3
adoroszlai opened a new pull request, #3557:
URL: https://github.com/apache/ozone/pull/3557
## What changes were proposed in this pull request?
* Bump Hadoop 3 dependency to 3.3.3.
* Exclude its new `reload4j` dependency (see [HADOOP-18088](https://issues.apache.org/jira/browse/HADOOP-18088)).
* Explicitly add `log4j` dependency in `hdds-server-framework`.
https://issues.apache.org/jira/browse/HDDS-6946
## How was this patch tested?
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/2563498128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang commented on a diff in pull request #3557: HDDS-6946. Bump Hadoop to 3.3.3
Posted by GitBox <gi...@apache.org>.
jojochuang commented on code in PR #3557:
URL: https://github.com/apache/ozone/pull/3557#discussion_r907553210
##########
hadoop-hdds/hadoop-dependency-server/pom.xml:
##########
@@ -71,6 +71,22 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd">
<groupId>com.sun.jersey</groupId>
<artifactId>jersey-json</artifactId>
</exclusion>
+ <exclusion>
+ <groupId>log4j</groupId>
+ <artifactId>log4j</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>ch.qos.reload4j</groupId>
+ <artifactId>reload4j</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
Review Comment:
i haven't checked but was it necessary to exclude slf4j-log4j12 and log4j?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3557: HDDS-6946. Bump Hadoop to 3.3.3
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3557:
URL: https://github.com/apache/ozone/pull/3557#discussion_r907597480
##########
hadoop-hdds/hadoop-dependency-server/pom.xml:
##########
@@ -71,6 +71,22 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd">
<groupId>com.sun.jersey</groupId>
<artifactId>jersey-json</artifactId>
</exclusion>
+ <exclusion>
+ <groupId>log4j</groupId>
+ <artifactId>log4j</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>ch.qos.reload4j</groupId>
+ <artifactId>reload4j</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
Review Comment:
I don't think they are strictly necessary. They used to be excluded in client dependencies, but not in server dependencies. I added them here for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3557: HDDS-6946. Bump Hadoop to 3.3.3
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3557:
URL: https://github.com/apache/ozone/pull/3557#issuecomment-1169946103
> So, this upgrade might create trouble for downstream projects
Thanks @ayushtkn for the info. I don't think this is urgent, so marked as draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3557: HDDS-6946. Bump Hadoop to 3.3.4
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3557:
URL: https://github.com/apache/ozone/pull/3557#issuecomment-1276702777
Thanks @ayushtkn, @jojochuang, @smengcl for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3557: HDDS-6946. Bump Hadoop to 3.3.4
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3557:
URL: https://github.com/apache/ozone/pull/3557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org