You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2021/04/08 15:57:24 UTC

[GitHub] [thrift] fishy commented on pull request #2359: THRIFT-5369: Use MaxMessageSize to check container sizes

fishy commented on pull request #2359:
URL: https://github.com/apache/thrift/pull/2359#issuecomment-815943220


   As mentioned in https://github.com/jaegertracing/jaeger/issues/2638#issuecomment-815859394, I reverted the compiler changes from this PR as they have negative performance impacts for everyone and it doesn't seem they are really necessary to fix the memory issue. We can have a follow up PR to add them back if they are proven to be necessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org