You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Michal Karm <mi...@gmail.com> on 2017/10/18 20:39:39 UTC

APR Util: Migrating Win64 build from 1.5.x to 1.6.x; testcrypto fails, looking for NSS

Hi guys,

I've switched my Windows CI from APR Util 1.5.x
to the 1.6.x branch. Little did I know it would
demand NSS even though I built with OpenSSL.

This is the pertinent excerpt from the log [1],
the full build log (large text) can be found here [2]
and last but not least, this is the build script [3],
note that I tried to set -DAPU_HAVE_NSS=OFF out of good
sport, but it was in vain.

Could you tell me what might be improved in the
CMakeLists.txt so as the test run doesn't look for NSS?

Is there anything else fishy about it? Perhaps the root
cause is entirely different.

Thank you for any pointers


Cheers

Karm

[1] https://www.hastebin.com/umitizokor.lua
[2] https://ci.modcluster.io/job/apr-util-windows/15/label=w2k12r2/consoleText
[3]
https://github.com/modcluster/ci.modcluster.io/blob/6a01bf9f015224271078336eebab4e258b8f9196/windows/apr-util/build.bat#L28

Michal Karm Babacek

-- 
Sent from my Hosaka Ono-Sendai Cyberspace 7



Re: APR Util: Migrating Win64 build from 1.5.x to 1.6.x; testcrypto fails, looking for NSS

Posted by Michal Karm <mi...@gmail.com>.
On 10/19/2017 10:57 AM, jean-frederic clere wrote:
> On 10/18/2017 10:39 PM, Michal Karm wrote:
>> Hi guys,
>>
>> I've switched my Windows CI from APR Util 1.5.x
>> to the 1.6.x branch. Little did I know it would
>> demand NSS even though I built with OpenSSL.
>>
>> This is the pertinent excerpt from the log [1],
>> the full build log (large text) can be found here [2]
>> and last but not least, this is the build script [3],
>> note that I tried to set -DAPU_HAVE_NSS=OFF out of good
>> sport, but it was in vain.
>>
>> Could you tell me what might be improved in the
>> CMakeLists.txt so as the test run doesn't look for NSS?
>
> If you look to test/testcrypto.c  it seems it require nss and openssl, I think
> it should be possible to test for nss and skip the corresponding tests...
> Patches are welcome
>
Patched on https://bz.apache.org/bugzilla/show_bug.cgi?id=61636

Cheers
Karm

> Cheers
>
> Jean-Frederic
>
>>
>> Is there anything else fishy about it? Perhaps the root
>> cause is entirely different.
>>
>> Thank you for any pointers
>>
>>
>> Cheers
>>
>> Karm
>>
>> [1] https://www.hastebin.com/umitizokor.lua
>> [2] https://ci.modcluster.io/job/apr-util-windows/15/label=w2k12r2/consoleText
>> [3]
>> https://github.com/modcluster/ci.modcluster.io/blob/6a01bf9f015224271078336eebab4e258b8f9196/windows/apr-util/build.bat#L28
>>
>>
>> Michal Karm Babacek
>>
>
>

Michal Karm Babacek

-- 
Sent from my Hosaka Ono-Sendai Cyberspace 7



Re: APR Util: Migrating Win64 build from 1.5.x to 1.6.x; testcrypto fails, looking for NSS

Posted by jean-frederic clere <jf...@gmail.com>.
On 10/18/2017 10:39 PM, Michal Karm wrote:
> Hi guys,
> 
> I've switched my Windows CI from APR Util 1.5.x
> to the 1.6.x branch. Little did I know it would
> demand NSS even though I built with OpenSSL.
> 
> This is the pertinent excerpt from the log [1],
> the full build log (large text) can be found here [2]
> and last but not least, this is the build script [3],
> note that I tried to set -DAPU_HAVE_NSS=OFF out of good
> sport, but it was in vain.
> 
> Could you tell me what might be improved in the
> CMakeLists.txt so as the test run doesn't look for NSS?

If you look to test/testcrypto.c  it seems it require nss and openssl, I 
think it should be possible to test for nss and skip the corresponding 
tests... Patches are welcome

Cheers

Jean-Frederic

> 
> Is there anything else fishy about it? Perhaps the root
> cause is entirely different.
> 
> Thank you for any pointers
> 
> 
> Cheers
> 
> Karm
> 
> [1] https://www.hastebin.com/umitizokor.lua
> [2] https://ci.modcluster.io/job/apr-util-windows/15/label=w2k12r2/consoleText
> [3]
> https://github.com/modcluster/ci.modcluster.io/blob/6a01bf9f015224271078336eebab4e258b8f9196/windows/apr-util/build.bat#L28
> 
> Michal Karm Babacek
> 


Re: APR Util: Migrating Win64 build from 1.5.x to 1.6.x; testcrypto fails, looking for NSS

Posted by William A Rowe Jr <wr...@rowe-clan.net>.
Looking at testcrypto.c, this never worked, not on Linux or Windows
or anywhere, so it's not a regression. It's an all-or-nothing review of
both schemas indiscriminately, whenever APU_HAVE_CRYPTO is
defined. It ignores the presence of NSS vs OPENSSL.

We didn't do this with the many other multiple-provider schemas,
I guess this is just special?

In any case, it's an alert but not critical, unless you attempted to
build both crypto providers.


On Wed, Oct 18, 2017 at 3:39 PM, Michal Karm <mi...@gmail.com> wrote:
> Hi guys,
>
> I've switched my Windows CI from APR Util 1.5.x
> to the 1.6.x branch. Little did I know it would
> demand NSS even though I built with OpenSSL.
>
> This is the pertinent excerpt from the log [1],
> the full build log (large text) can be found here [2]
> and last but not least, this is the build script [3],
> note that I tried to set -DAPU_HAVE_NSS=OFF out of good
> sport, but it was in vain.
>
> Could you tell me what might be improved in the
> CMakeLists.txt so as the test run doesn't look for NSS?
>
> Is there anything else fishy about it? Perhaps the root
> cause is entirely different.
>
> Thank you for any pointers
>
>
> Cheers
>
> Karm
>
> [1] https://www.hastebin.com/umitizokor.lua
> [2] https://ci.modcluster.io/job/apr-util-windows/15/label=w2k12r2/consoleText
> [3]
> https://github.com/modcluster/ci.modcluster.io/blob/6a01bf9f015224271078336eebab4e258b8f9196/windows/apr-util/build.bat#L28
>
> Michal Karm Babacek
>
> --
> Sent from my Hosaka Ono-Sendai Cyberspace 7
>
>