[GitHub] [iceberg] aokolnychyi commented on a change in pull request #1868: Core: Add table properties for snapshot retention

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #1868:
URL: https://github.com/apache/iceberg/pull/1868#discussion_r535258124



##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -140,4 +140,10 @@ private TableProperties() {
 
   public static final String GC_ENABLED = "gc.enabled";
   public static final boolean GC_ENABLED_DEFAULT = true;
+
+  public static final String MAX_SNAPSHOT_AGE_MS = "history.expire.max-snapshot-age-ms";
+  public static final long MAX_SNAPSHOT_AGE_MS_DEFAULT = 5 * 24 * 60 * 60 * 1000; // 5 days
+
+  public static final String RETAIN_MIN_NUM_SNAPSHOTS = "history.expire.retain-min-num-snapshots";
+  public static final int RETAIN_MIN_NUM_SNAPSHOTS_DEFAULT = 1;

Review comment:
       This is not a particularly good default but we need it to keep the old behavior by default.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org