You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/29 20:00:13 UTC
[GitHub] [airflow] jedcunningham opened a new pull request #15595: Adds log persistence to helm chart
jedcunningham opened a new pull request #15595:
URL: https://github.com/apache/airflow/pull/15595
This adds the option to use a PVC (one provisioned by the chart or an
existing claim) to persist Airflow logs. This provides an executor
agnostic way to persist all of the Airflow logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #15595: Adds log persistence to helm chart
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15595:
URL: https://github.com/apache/airflow/pull/15595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15595: Adds log persistence to helm chart
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15595:
URL: https://github.com/apache/airflow/pull/15595#discussion_r623409574
##########
File path: docs/helm-chart/manage-logs.rst
##########
@@ -0,0 +1,89 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+Manage logs
+=================
+
+You have a number of options when it comes to managing your Airflow logs.
+
+No persistence
+-----------------
+
+With this option, Airflow will log locally to each pod. As such, the logs will only be available during the lifetime of the pod.
+
+.. code-block:: bash
+
+ helm upgrade airflow . \
+ --set logs.persistence.enabled=false
+ # --set workers.persistence.enabled=false (also needed if using ``CeleryExecutor``)
+
+Celery worker log persistence
+-----------------------------
+
+If you are using ``CeleryExecutor``, workers persist logs by default to a volume claim created with a ``volumeClaimTemplate``.
+
+You can modify the template:
+
+.. code-block:: bash
+
+ helm upgrade airflow . \
+ --set executor=CeleryExecutor \
+ --set workers.persistence.size=10Gi
+
+Note with this option only task logs are persisted, unlike when log persistence is enabled which will also persist scheduler logs.
+
+Log persistence enabled
+-----------------------
+
+This option will provision a PersistentVolumeClaim with an access mode of ``ReadWriteMany``. Each component of Airflow will
Review comment:
```suggestion
This option will provision a ``PersistentVolumeClaim`` with an access mode of ``ReadWriteMany``. Each component of Airflow will
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15595: Adds log persistence to helm chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15595:
URL: https://github.com/apache/airflow/pull/15595#issuecomment-829605752
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org