You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "slavkap (via GitHub)" <gi...@apache.org> on 2023/05/19 09:28:34 UTC
[GitHub] [cloudstack] slavkap opened a new pull request, #7539: Volume encryption support for StorPool plug-in
slavkap opened a new pull request, #7539:
URL: https://github.com/apache/cloudstack/pull/7539
### Description
Support of volume encryption for the StorPool plugin
Supported Virtual machine operations:
- live migration of VM to another host
- virtual machine snapshots (group snapshots without memory)
- revert VM snapshot
- delete VM snapshot
Supported Volume operations:
- attach/detach volume
- live migrate volume between two StorPool primary storages
- volume snapshot
- delete snapshot
- revert snapshot
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [X] Major
- [ ] Minor
### How Has This Been Tested?
Environment:
CS mgmt - Rocky Linux
2 KVM hypervisors - Rocky
Smoke and manual tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7539: Volume encryption support for StorPool plug-in
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7539:
URL: https://github.com/apache/cloudstack/pull/7539#issuecomment-1603997419
@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7539: Volume encryption support for StorPool plug-in
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7539:
URL: https://github.com/apache/cloudstack/pull/7539#issuecomment-1603063507
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7539: Volume encryption support for StorPool plug-in
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7539:
URL: https://github.com/apache/cloudstack/pull/7539#issuecomment-1603996849
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7539: Volume encryption support for StorPool plug-in
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7539:
URL: https://github.com/apache/cloudstack/pull/7539#issuecomment-1604156114
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7539: Volume encryption support for StorPool plug-in
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7539:
URL: https://github.com/apache/cloudstack/pull/7539#issuecomment-1604065338
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7539: Volume encryption support for StorPool plug-in
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7539:
URL: https://github.com/apache/cloudstack/pull/7539#issuecomment-1554367379
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/7539?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7539](https://app.codecov.io/gh/apache/cloudstack/pull/7539?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2bc8fca) into [4.18](https://app.codecov.io/gh/apache/cloudstack/commit/22871ad2da8b72becd46573ac4e2bc46a3f79407?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (22871ad) will **increase** coverage by `12.93%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## 4.18 #7539 +/- ##
===========================================
+ Coverage 0 12.93% +12.93%
- Complexity 0 8948 +8948
===========================================
Files 0 2719 +2719
Lines 0 256290 +256290
Branches 0 39964 +39964
===========================================
+ Hits 0 33139 +33139
- Misses 0 218991 +218991
- Partials 0 4160 +4160
```
| [Impacted Files](https://app.codecov.io/gh/apache/cloudstack/pull/7539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../src/main/java/com/cloud/host/dao/HostDaoImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9ob3N0L2Rhby9Ib3N0RGFvSW1wbC5qYXZh) | `27.85% <0.00%> (ø)` | |
| [...api/storage/StorPoolSetVolumeEncryptionAnswer.java](https://app.codecov.io/gh/apache/cloudstack/pull/7539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9zdG9yYWdlL3ZvbHVtZS9zdG9ycG9vbC9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9hZ2VudC9hcGkvc3RvcmFnZS9TdG9yUG9vbFNldFZvbHVtZUVuY3J5cHRpb25BbnN3ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pi/storage/StorPoolSetVolumeEncryptionCommand.java](https://app.codecov.io/gh/apache/cloudstack/pull/7539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9zdG9yYWdlL3ZvbHVtZS9zdG9ycG9vbC9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9hZ2VudC9hcGkvc3RvcmFnZS9TdG9yUG9vbFNldFZvbHVtZUVuY3J5cHRpb25Db21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...per/StorPoolSetVolumeEncryptionCommandWrapper.java](https://app.codecov.io/gh/apache/cloudstack/pull/7539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9zdG9yYWdlL3ZvbHVtZS9zdG9ycG9vbC9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9oeXBlcnZpc29yL2t2bS9yZXNvdXJjZS93cmFwcGVyL1N0b3JQb29sU2V0Vm9sdW1lRW5jcnlwdGlvbkNvbW1hbmRXcmFwcGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...tastore/driver/StorPoolPrimaryDataStoreDriver.java](https://app.codecov.io/gh/apache/cloudstack/pull/7539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9zdG9yYWdlL3ZvbHVtZS9zdG9ycG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9zdG9yYWdlL2RhdGFzdG9yZS9kcml2ZXIvU3RvclBvb2xQcmltYXJ5RGF0YVN0b3JlRHJpdmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ack/storage/motion/StorPoolDataMotionStrategy.java](https://app.codecov.io/gh/apache/cloudstack/pull/7539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9zdG9yYWdlL3ZvbHVtZS9zdG9ycG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9zdG9yYWdlL21vdGlvbi9TdG9yUG9vbERhdGFNb3Rpb25TdHJhdGVneS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/java/com/cloud/storage/VolumeApiServiceImpl.java](https://app.codecov.io/gh/apache/cloudstack/pull/7539?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3N0b3JhZ2UvVm9sdW1lQXBpU2VydmljZUltcGwuamF2YQ==) | `14.65% <0.00%> (ø)` | |
... and [2712 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/7539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #7539: Volume encryption support for StorPool plug-in
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #7539:
URL: https://github.com/apache/cloudstack/pull/7539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #7539: Volume encryption support for StorPool plug-in
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #7539:
URL: https://github.com/apache/cloudstack/pull/7539#issuecomment-1603064511
@slavkap
the code not related to storpool looks goood to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7539: Volume encryption support for StorPool plug-in
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7539:
URL: https://github.com/apache/cloudstack/pull/7539#issuecomment-1605195159
<b>[SF] Trillian test result (tid-6829)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45811 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7539-t6829-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 85.93 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 57.51 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7539: Volume encryption support for StorPool plug-in
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7539:
URL: https://github.com/apache/cloudstack/pull/7539#issuecomment-1604156913
@DaanHoogland a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org