You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2019/03/29 23:53:53 UTC

[GitHub] [incubator-heron] dnrusakov opened a new pull request #3230: memory leak in tmaster fixed

dnrusakov opened a new pull request #3230: memory leak in tmaster fixed
URL: https://github.com/apache/incubator-heron/pull/3230
 
 
   The memory leak in TMaster was reported by one of the Twitter internal clients.
   After running TMaster under Valgrind memory leaks detector, the leak was localized.
   This PR aims to fix it. 
   
   `GetStmgrsRegSummary()` now returns a smart pointer (`unique_ptr<>`). So, as soon as a caller no need the returned result anymore the memory is freed automatically.
   
   Tested this PR locally under Valgrind and don't see the leak anymore.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services