You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2025/06/07 10:07:47 UTC

[PR] [EXPERIMENT] try Java 25-ea [pekko]

pjfanning opened a new pull request, #1887:
URL: https://github.com/apache/pekko/pull/1887

   relates to #1534 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] [EXPERIMENT] try Java 25-ea [pekko]

Posted by "mkurz (via GitHub)" <gi...@apache.org>.
mkurz commented on PR #1887:
URL: https://github.com/apache/pekko/pull/1887#issuecomment-3298777183

   Java 25 officially released: https://mail.openjdk.org/pipermail/announce/2025-September/000360.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] [EXPERIMENT] try Java 25-ea [pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1887:
URL: https://github.com/apache/pekko/pull/1887#issuecomment-3299272345

   it should be -release 17


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] [EXPERIMENT] try Java 25-ea [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1887:
URL: https://github.com/apache/pekko/pull/1887#issuecomment-3353650107

   https://github.com/apache/pekko/issues/1998 still seems to be an issue - 44 tests failed for pekko-remote with Artery in latest run here.
   Otherwise, there are some failures in other tests but not as bad as before.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] [EXPERIMENT] try Java 25-ea [pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1887:
URL: https://github.com/apache/pekko/pull/1887#issuecomment-3353385620

   Should we retry this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] some nightly tests with Java 25 [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1887:
URL: https://github.com/apache/pekko/pull/1887#discussion_r2529843343


##########
.github/workflows/nightly-builds.yml:
##########
@@ -170,8 +169,7 @@ jobs:
             "++ ${{ matrix.scalaVersion }} doc"
 
       - name: Publish
-        # Publish (osgi bundle) not working with JDK 17, issue #31132
-        if: ${{ matrix.javaVersion == 11 }}
+        if: ${{ matrix.javaVersion == 17 }}

Review Comment:
   if this fails, we'll have to fix it or drop this testing altogether - it is effectively disabled prior to this change because Java 17 is the min version used in the build



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] [EXPERIMENT] try Java 25-ea [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1887:
URL: https://github.com/apache/pekko/pull/1887#issuecomment-3299547723

   > it should be -release 17
   
   We have flags like that in the build but still we end up with invalid classes that cause pattern matching issues (as far as I recall).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] [EXPERIMENT] try Java 25-ea [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1887:
URL: https://github.com/apache/pekko/pull/1887#issuecomment-3298844568

   The open issues are at https://github.com/apache/pekko/issues?q=state%3Aopen%20label%3Ajava24%2F25
   
   The TLDR is that Java 24 and 25 compilers seems to compile Pekko code but it doesn't work as normal at runtime. If we build Pekko with an older Java compiler (eg Java 17), the compiled classes work at runtime with Java 24 and 25 - as far as I can see.
   
   If anyone has time to investigate why the Java compiler is behaving like this, feel free to take this on - it would be very useful. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] [EXPERIMENT] try Java 25-ea [pekko]

Posted by "EmadAlblueshi (via GitHub)" <gi...@apache.org>.
EmadAlblueshi commented on PR #1887:
URL: https://github.com/apache/pekko/pull/1887#issuecomment-3298817483

   > Cool, we should make 2.0.0 release jdk25 ready.
   
   That would be great 👍🏻 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] some nightly tests with Java 25 [pekko]

Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof merged PR #1887:
URL: https://github.com/apache/pekko/pull/1887


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] [EXPERIMENT] try Java 25-ea [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #1887:
URL: https://github.com/apache/pekko/pull/1887#issuecomment-3299672528

   with Java 25-ea (GitHub CI does seem to have a Temurin distro for Java 25 yet), we get Scala code gen issues (similar issues in pekko-http build).
   
   ```
   [info] Generating 'ZipLatestWith.scala'
   [info] Generating 'UnzipWith.scala'
   [info] Generating 'ZipWith.scala'
   [info] Generating 'GraphCreate.scala'
   [info] Generating 'FanInShapeN.scala'
   [info] Generating 'FanOutShapeN.scala'
   [info] Generating 'GraphApply.scala'
   [info] Generating 'ZipLatestWithApply.scala'
   [info] Generating 'UnzipWithApply.scala'
   [info] Generating 'ZipWithApply.scala'
   [info] Generating 'Tuples.scala'
   [info] Generating 'Functions.scala'
   [info] compiling 203 Scala sources and 27 Java sources to /home/runner/work/pekko/pekko/actor/target/scala-2.13/classes ...
   [error] Error while emitting SameThreadExecutionContext.scala
   [error] Unsupported class file major version 69
   [error] Error while emitting ScalaBatchable.scala
   [error] Unsupported class file major version 69
   [error] Error while emitting ByteIterator.scala
   [error] assertion failed: ClassBType.info not yet assigned: Ljava/lang/Object;
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] [EXPERIMENT] try Java 25-ea [pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1887:
URL: https://github.com/apache/pekko/pull/1887#issuecomment-3134766178

   Cool, we should make 2.0.0 release jdk25 ready.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] some nightly tests with Java 25 [pekko]

Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #1887:
URL: https://github.com/apache/pekko/pull/1887#discussion_r2529840546


##########
.github/workflows/nightly-builds.yml:
##########
@@ -170,8 +169,7 @@ jobs:
             "++ ${{ matrix.scalaVersion }} doc"
 
       - name: Publish
-        # Publish (osgi bundle) not working with JDK 17, issue #31132
-        if: ${{ matrix.javaVersion == 11 }}
+        if: ${{ matrix.javaVersion == 17 }}

Review Comment:
   so this was fixed? I guess we'll see :)



##########
.github/workflows/nightly-builds.yml:
##########
@@ -160,8 +160,7 @@ jobs:
             clean "++ ${{ matrix.scalaVersion }} test" checkTestsHaveRun
 
       - name: Docs
-        # Docs generation requires JDK 11.
-        if: ${{ matrix.javaVersion == 11 }}

Review Comment:
   huh ;)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] some nightly tests with Java 25 [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1887:
URL: https://github.com/apache/pekko/pull/1887#discussion_r2529842948


##########
.github/workflows/nightly-builds.yml:
##########
@@ -160,8 +160,7 @@ jobs:
             clean "++ ${{ matrix.scalaVersion }} test" checkTestsHaveRun
 
       - name: Docs
-        # Docs generation requires JDK 11.
-        if: ${{ matrix.javaVersion == 11 }}

Review Comment:
   docs build ok with Java 17 now - after Paradox fixes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org