[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #847: PHOENIX-6022 RVC Offset does not handle trailing nulls properly

[GitBox <gi...@apache.org>]

ChinmaySKulkarni commented on a change in pull request #847:
URL: https://github.com/apache/phoenix/pull/847#discussion_r461882818



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/compile/RVCOffsetCompiler.java
##########
@@ -240,34 +246,41 @@ public CompiledOffset getRVCOffset(StatementContext context, FilterableStatement
             }
         }
 
+        byte[] key;
+
         // check to see if this was a single key expression
         ScanRanges scanRanges = context.getScanRanges();
 
+        //We do not generate a point lookup today in phoenix if the rowkey has a trailing null, we generate a range scan.
         if (!scanRanges.isPointLookup()) {

Review comment:
       I guess pushing the logic for trailing null inside the isPointLookup() API is a bigger change that's too risky?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org