You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/01 15:20:42 UTC

[GitHub] [spark] MaxGekk commented on pull request #31675: [SPARK-34560][SQL] Generate unique output attributes in the `SHOW TABLES` logical node

MaxGekk commented on pull request #31675:
URL: https://github.com/apache/spark/pull/31675#issuecomment-788029728


   > Shall we simply make this fix for all the existing commands that have output in the constructor parameter (should be less than 5) without tests as the issue is so obvious?
   
   I would propose to have one test for at least the command `SHOW TABLES` (to prevent future problems while refactoring/fixing like https://issues.apache.org/jira/browse/SPARK-34156), and just fix other logical nodes w/o tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org