You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2023/12/20 08:27:01 UTC
[PR] [SPARK-46462][PS][TESTS] Reorganize `OpsOnDiffFramesGroupByRollingTests` [spark]
zhengruifeng opened a new pull request, #44420:
URL: https://github.com/apache/spark/pull/44420
### What changes were proposed in this pull request?
Reorganize `OpsOnDiffFramesGroupByRollingTests`
### Why are the changes needed?
for parallelism
### Does this PR introduce _any_ user-facing change?
no, test-only
### How was this patch tested?
ci
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46462][PS][TESTS] Reorganize `OpsOnDiffFramesGroupByRollingTests` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44420:
URL: https://github.com/apache/spark/pull/44420#discussion_r1433287846
##########
dev/sparktestsupport/modules.py:
##########
@@ -742,10 +742,14 @@ def __hash__(self):
"pyspark.pandas.tests.test_internal",
"pyspark.pandas.tests.test_namespace",
"pyspark.pandas.tests.test_numpy_compat",
+ "pyspark.pandas.tests.test_ops_on_diff_frames_groupby_rolling",
+ "pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling",
+ "pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling_adv",
+ "pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling_count",
+ "pyspark.pandas.tests.test_ops_on_diff_frames_groupby_expanding",
Review Comment:
```suggestion
"pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling_adv",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling_count",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46462][PS][TESTS] Reorganize `OpsOnDiffFramesGroupByRollingTests` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44420:
URL: https://github.com/apache/spark/pull/44420#discussion_r1433288126
##########
dev/sparktestsupport/modules.py:
##########
@@ -742,10 +742,12 @@ def __hash__(self):
"pyspark.pandas.tests.test_internal",
"pyspark.pandas.tests.test_namespace",
"pyspark.pandas.tests.test_numpy_compat",
+ "pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling",
+ "pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling_adv",
+ "pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling_count",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_expanding",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_expanding_adv",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_expanding_count",
Review Comment:
```suggestion
"pyspark.pandas.tests.diff_frames_ops.test_groupby_expanding",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_expanding_adv",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_expanding_count",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling_adv",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling_count",
```
##########
dev/sparktestsupport/modules.py:
##########
@@ -742,10 +742,14 @@ def __hash__(self):
"pyspark.pandas.tests.test_internal",
"pyspark.pandas.tests.test_namespace",
"pyspark.pandas.tests.test_numpy_compat",
+ "pyspark.pandas.tests.test_ops_on_diff_frames_groupby_rolling",
+ "pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling",
+ "pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling_adv",
+ "pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling_count",
+ "pyspark.pandas.tests.test_ops_on_diff_frames_groupby_expanding",
Review Comment:
```suggestion
"pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling_adv",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling_count",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46462][PS][TESTS] Reorganize `OpsOnDiffFramesGroupByRollingTests` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44420:
URL: https://github.com/apache/spark/pull/44420#issuecomment-1865291376
Merged to master.
The tests already passed, and I just resolve the minor conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46462][PS][TESTS] Reorganize `OpsOnDiffFramesGroupByRollingTests` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44420:
URL: https://github.com/apache/spark/pull/44420#discussion_r1433288126
##########
dev/sparktestsupport/modules.py:
##########
@@ -742,10 +742,12 @@ def __hash__(self):
"pyspark.pandas.tests.test_internal",
"pyspark.pandas.tests.test_namespace",
"pyspark.pandas.tests.test_numpy_compat",
+ "pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling",
+ "pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling_adv",
+ "pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling_count",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_expanding",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_expanding_adv",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_expanding_count",
Review Comment:
```suggestion
"pyspark.pandas.tests.diff_frames_ops.test_groupby_expanding",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_expanding_adv",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_expanding_count",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling_adv",
"pyspark.pandas.tests.diff_frames_ops.test_groupby_rolling_count",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46462][PS][TESTS] Reorganize `OpsOnDiffFramesGroupByRollingTests` [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #44420: [SPARK-46462][PS][TESTS] Reorganize `OpsOnDiffFramesGroupByRollingTests`
URL: https://github.com/apache/spark/pull/44420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org