You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "PragmaTwice (via GitHub)" <gi...@apache.org> on 2023/02/04 10:05:51 UTC

[GitHub] [incubator-kvrocks] PragmaTwice opened a new pull request, #1244: Split redis_cmd.cc to multiple files by category

PragmaTwice opened a new pull request, #1244:
URL: https://github.com/apache/incubator-kvrocks/pull/1244

   It closes #1138.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1244: Split redis_cmd.cc to multiple files by category

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #1244:
URL: https://github.com/apache/incubator-kvrocks/pull/1244#issuecomment-1416909011

   Thanks all. Merging...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] caipengbo commented on pull request #1244: Split redis_cmd.cc to multiple files by category

Posted by "caipengbo (via GitHub)" <gi...@apache.org>.
caipengbo commented on PR #1244:
URL: https://github.com/apache/incubator-kvrocks/pull/1244#issuecomment-1416743746

   How about dropping the prefix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice merged pull request #1244: Split redis_cmd.cc to multiple files by category

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice merged PR #1244:
URL: https://github.com/apache/incubator-kvrocks/pull/1244


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1244: Split redis_cmd.cc to multiple files by category

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #1244:
URL: https://github.com/apache/incubator-kvrocks/pull/1244#issuecomment-1416731845

   > Isn't the `redis_cmd_` prefix a bit redundant?
   
   I am considering `cmd_*`, since there are other source files in this directory.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] caipengbo commented on pull request #1244: Split redis_cmd.cc to multiple files by category

Posted by "caipengbo (via GitHub)" <gi...@apache.org>.
caipengbo commented on PR #1244:
URL: https://github.com/apache/incubator-kvrocks/pull/1244#issuecomment-1416728308

   Isn't the `redis_cmd_` prefix a bit redundant?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1244: Split redis_cmd.cc to multiple files by category

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #1244:
URL: https://github.com/apache/incubator-kvrocks/pull/1244#issuecomment-1416748328

   @caipengbo @hulk I did some rename:
   ```
   scan_util.h -> scan_base.h
   redis_cmd.{h|cc} -> commander.{h|cc}
   redis_cmd_*.{h|cc} -> cmd_*.{h|cc}
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1244: Split redis_cmd.cc to multiple files by category

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #1244:
URL: https://github.com/apache/incubator-kvrocks/pull/1244#issuecomment-1416745278

   > How about dropping the prefix?
   
   I think the prefix can make them more distinguishing than other source files in alphabetical order, e.g.
   ```
   cmd_a
   b
   cmd_c
   d
   cmd_e
   ```
   than
   ```
   b
   cmd_a
   cmd_c
   cmd_e
   d
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1244: Split redis_cmd.cc to multiple files by category

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #1244:
URL: https://github.com/apache/incubator-kvrocks/pull/1244#issuecomment-1416733571

   Though, the current one is acceptable for me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org