[GitHub] [incubator-netbeans] matthiasblaesing commented on issue #1167: NETBEANS-2263 Integrate the localisation bundles from Oracle's 3rd donation into the current GitHub repository

[GitBox <gi...@apache.org>]

matthiasblaesing commented on issue #1167: NETBEANS-2263 Integrate the localisation bundles from Oracle's 3rd donation into the current GitHub repository
URL: https://github.com/apache/incubator-netbeans/pull/1167#issuecomment-474586340
 
 
   Thank you - I'll only comment on the license side of the import. I want an opinion from others more knowledgeable of the l10n part of the netbeans infrastructure, if the source code location is sensible and/or if we should open a separate repository of the the l10n data.
   
   - the procedure you described to verify, that only donated files were imported works (I had to rename my intermediate directory from the netbeans-l10n.zip, but that works ok). The first commit is ok from my POV.
   - the license change (second commit) is good to be separated, as it turns out, it is not complete:
   ```shell
   # Get the files, that were imported (first commit)
   git diff --name-only c6eb7aa76370f9a059736b686ba2b1f5f622e87c..328b07c6203fa2268c49bb0bd6b7c9d51636ddc4 | sort > imported.txt
   # Get the files, that had changes (this assumes, that the license header was updated) (second commit)
   git diff --name-only 328b07c6203fa2268c49bb0bd6b7c9d51636ddc4..3fc7acd08836cc736d96c81fe53f3b6efaad2445 | sort > modfied.txt
   # both lists should match, as it is assumed, that all files carry the Oracle/Sun CDDL/GPLv2CP header and so output should be empty
   diff imported.txt modfied.txt 
   ```
   
   Running the output of diff through diffstat reveals, that 6287 were not caught. My gut feeling tells me, that you missed the files, that Oracle inherited from Sun and never updated.
   - the change in the ignore file looks sane
   - the build change (last commit) looks ok, as we target JDK8 as minimum runtime JDK

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists