You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/03/04 23:37:00 UTC

[jira] [Work logged] (BEAM-14051) There should be single source of truth for the project version

     [ https://issues.apache.org/jira/browse/BEAM-14051?focusedWorklogId=736964&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-736964 ]

ASF GitHub Bot logged work on BEAM-14051:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Mar/22 23:36
            Start Date: 04/Mar/22 23:36
    Worklog Time Spent: 10m 
      Work Description: dmitryor opened a new pull request #17022:
URL: https://github.com/apache/beam/pull/17022


   Suggest to also update the version in BeamModulePlugin.groovy if you
   need to customize it.
   
   R:@robertwb
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 736964)
    Remaining Estimate: 0h
            Time Spent: 10m

> There should be single source of truth for the project version
> --------------------------------------------------------------
>
>                 Key: BEAM-14051
>                 URL: https://issues.apache.org/jira/browse/BEAM-14051
>             Project: Beam
>          Issue Type: Wish
>          Components: build-system
>            Reporter: Dmitry Orlovsky
>            Priority: P3
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Now the Beam version is defined in two places:
>  * via the 'version' parameter [in gradle.properties|https://github.com/apache/beam/blob/master/gradle.properties#L27],
>  * programmatically in the `apply` function [in BeamModulePlugin|[https://github.com/apache/beam/blob/master/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L384-L387].]
> The latter effectively overrides the former. For someone not very familiar with the Beam build system this may result in a hard to understand and debug behavior: unexpected version gets build and/or pushed to local Maven repository, and changing version in `gradle.properties` does not have any effect.
> Adding a comment with a reference to `BeamModulePlugin` to `gradle.properties` can be a good start, and in the long run it would be great to have single source of truth for the project version.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)