You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/11/15 03:10:42 UTC

[GitHub] [rocketmq] ShannonDing commented on a diff in pull request #5520: [ISSUE #5519] Admin command support update multiple pairs config.

ShannonDing commented on code in PR #5520:
URL: https://github.com/apache/rocketmq/pull/5520#discussion_r1022272420


##########
tools/src/main/java/org/apache/rocketmq/tools/command/broker/UpdateBrokerConfigSubCommand.java:
##########
@@ -117,4 +119,23 @@ public void execute(CommandLine commandLine, Options options, RPCHook rpcHook) t
             defaultMQAdminExt.shutdown();
         }
     }
+
+    public Properties getUpdatedConfig(CommandLine commandLine) {

Review Comment:
   Is it possible to put this function implementation into CommandUtils？ so that it will not be written twice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org