[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5657: Using dictionary based aggregation operator when there is no filter/g…

[GitBox <gi...@apache.org>]

mayankshriv commented on a change in pull request #5657:
URL: https://github.com/apache/incubator-pinot/pull/5657#discussion_r449824650



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/plan/maker/InstancePlanMakerImplV2.java
##########
@@ -164,7 +164,8 @@ static boolean isFitForDictionaryBasedPlan(QueryContext queryContext, IndexSegme
     for (ExpressionContext expression : selectExpressions) {
       FunctionContext function = expression.getFunction();
       String functionName = function.getFunctionName();
-      if (!functionName.equals("min") && !functionName.equals("max") && !functionName.equals("minmaxrange")) {
+      if (!functionName.equals("min") && !functionName.equals("max") && !functionName.equals("minmaxrange")

Review comment:
       Would be good to use `AggregationFunctionType` instead of string name. Also, would be good to factor out as `isFunctionFitForDictionaryBasedComputation` in say `AggregationFunctionUtils`, for readability.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org