You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Pua (Jira)" <ji...@apache.org> on 2020/08/27 17:07:01 UTC
[jira] [Commented] (FLINK-19051) Exception message should be
reserved in log When the Job Manager failed
[ https://issues.apache.org/jira/browse/FLINK-19051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185986#comment-17185986 ]
Pua commented on FLINK-19051:
-----------------------------
[~jark] [~lzljs3620320],what do you think?
Now if job manager failed ,we can't get root cause from log.
> Exception message should be reserved in log When the Job Manager failed
> ------------------------------------------------------------------------
>
> Key: FLINK-19051
> URL: https://issues.apache.org/jira/browse/FLINK-19051
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Task
> Affects Versions: 1.12.0, 1.11.1
> Reporter: Pua
> Priority: Minor
>
> {code:java}
> protected void closeJobManagerConnection(JobID jobId, Exception cause) {
> JobManagerRegistration jobManagerRegistration = jobManagerRegistrations.remove(jobId);
> if (jobManagerRegistration != null) {
> final ResourceID jobManagerResourceId = jobManagerRegistration.getJobManagerResourceID();
> final JobMasterGateway jobMasterGateway = jobManagerRegistration.getJobManagerGateway();
> final JobMasterId jobMasterId = jobManagerRegistration.getJobMasterId();
> log.info("Disconnect job manager {}@{} for job {} from the resource manager.",
> jobMasterId,
> jobMasterGateway.getAddress(),
> jobId);
> jobManagerHeartbeatManager.unmonitorTarget(jobManagerResourceId);
> jmResourceIdRegistrations.remove(jobManagerResourceId);
> // tell the job manager about the disconnect
> jobMasterGateway.disconnectResourceManager(getFencingToken(), cause);
> } else {
> log.debug("There was no registered job manager for job {}.", jobId);
> }
> {code}
> Exception message should be reserved in log.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)