[GitHub] raphinesse commented on issue #195: Nightly builds are sometimes broken

[GitBox <gi...@apache.org>]

raphinesse commented on issue #195: Nightly builds are sometimes broken
URL: https://github.com/apache/cordova-coho/issues/195#issuecomment-418541253
 
 
   I find your analysis to be very plausible after a quick glance over the code. Given that there's already more sync stuff happening than async in this particular module (all the `shelljs` stuff is sync too), I would not object a fix that simply uses `fs.readFileSync`. An easy fix might be a good start anyway, so we can verify the fix in "production". But if you'd like to do a nice async version of this, I think nobody will be stopping you. Any PRs welcome!
   
   I particularly like that someone already found the error but chose to ignore it :sweat_smile:
   https://github.com/apache/cordova-coho/blob/5d710a3bb1838d1e822ee0ed4f830374c6c4b180/src/versionutil.js#L92-L93

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org