You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/04 23:18:55 UTC
[GitHub] [flink] suez1224 commented on a change in pull request #7978:
[FLINK-11910] [Yarn] add customizable yarn application type
suez1224 commented on a change in pull request #7978: [FLINK-11910] [Yarn] add customizable yarn application type
URL: https://github.com/apache/flink/pull/7978#discussion_r272401341
##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
##########
@@ -988,7 +992,7 @@ public ApplicationReport startAppMaster(
final String customApplicationName = customName != null ? customName : applicationName;
appContext.setApplicationName(customApplicationName);
- appContext.setApplicationType("Apache Flink");
+ appContext.setApplicationType(applicationType.isEmpty() ? "Apache Flink" : applicationType);
Review comment:
Can't we just do the following?
appContext.setApplicationType(dynProperties.getOrDefault("application-type", "Apache Flink"));
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services