You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jeremy Hanna (JIRA)" <ji...@apache.org> on 2010/05/28 18:42:36 UTC
[jira] Created: (CASSANDRA-1140) Add RandomPartitioner based system
tests
Add RandomPartitioner based system tests
----------------------------------------
Key: CASSANDRA-1140
URL: https://issues.apache.org/jira/browse/CASSANDRA-1140
Project: Cassandra
Issue Type: Test
Reporter: Jeremy Hanna
Assignee: Jeremy Hanna
Priority: Minor
Currently all of the system tests use the CollatingOrderPreservingPartitioner, likely because it has capabilities that the RandomPartitioner does not.
It would be nice if there were a separate set of tests for things specific to the RandomPartitioner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-1140) Add RandomPartitioner based
system tests
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Hanna reassigned CASSANDRA-1140:
---------------------------------------
Assignee: (was: Jeremy Hanna)
> Add RandomPartitioner based system tests
> ----------------------------------------
>
> Key: CASSANDRA-1140
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1140
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jeremy Hanna
> Priority: Minor
> Attachments: cassandra-1040-patch.txt
>
>
> Currently all of the system tests use the CollatingOrderPreservingPartitioner, likely because it has capabilities that the RandomPartitioner does not.
> It would be nice if there were a separate set of tests for things specific to the RandomPartitioner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1140) Add RandomPartitioner based
system tests
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874208#action_12874208 ]
Brandon Williams commented on CASSANDRA-1140:
---------------------------------------------
Manually applying the __init__.py changes is fairly trivial, if needed. +1
> Add RandomPartitioner based system tests
> ----------------------------------------
>
> Key: CASSANDRA-1140
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1140
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jeremy Hanna
> Assignee: Jeremy Hanna
> Priority: Minor
> Attachments: cassandra-1040-patch.txt
>
>
> Currently all of the system tests use the CollatingOrderPreservingPartitioner, likely because it has capabilities that the RandomPartitioner does not.
> It would be nice if there were a separate set of tests for things specific to the RandomPartitioner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1140) Add RandomPartitioner based
system tests
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877850#action_12877850 ]
Jeremy Hanna commented on CASSANDRA-1140:
-----------------------------------------
Okay - I thought you were talking about the configuration stuff, not the code itself. I'll look into making sure we reuse the code in there.
> Add RandomPartitioner based system tests
> ----------------------------------------
>
> Key: CASSANDRA-1140
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1140
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jeremy Hanna
> Assignee: Jeremy Hanna
> Priority: Minor
> Attachments: cassandra-1040-patch.txt
>
>
> Currently all of the system tests use the CollatingOrderPreservingPartitioner, likely because it has capabilities that the RandomPartitioner does not.
> It would be nice if there were a separate set of tests for things specific to the RandomPartitioner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1140) Add RandomPartitioner based
system tests
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874142#action_12874142 ]
Brandon Williams commented on CASSANDRA-1140:
---------------------------------------------
What rev was this against? I get failures applying to system/__init__.py
> Add RandomPartitioner based system tests
> ----------------------------------------
>
> Key: CASSANDRA-1140
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1140
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jeremy Hanna
> Assignee: Jeremy Hanna
> Priority: Minor
> Attachments: cassandra-1040-patch.txt
>
>
> Currently all of the system tests use the CollatingOrderPreservingPartitioner, likely because it has capabilities that the RandomPartitioner does not.
> It would be nice if there were a separate set of tests for things specific to the RandomPartitioner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1140) Add RandomPartitioner based system
tests
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Hanna updated CASSANDRA-1140:
------------------------------------
Attachment: cassandra-1040-patch.txt
> Add RandomPartitioner based system tests
> ----------------------------------------
>
> Key: CASSANDRA-1140
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1140
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jeremy Hanna
> Assignee: Jeremy Hanna
> Priority: Minor
> Attachments: cassandra-1040-patch.txt
>
>
> Currently all of the system tests use the CollatingOrderPreservingPartitioner, likely because it has capabilities that the RandomPartitioner does not.
> It would be nice if there were a separate set of tests for things specific to the RandomPartitioner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1140) Add RandomPartitioner based system
tests
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Hanna updated CASSANDRA-1140:
------------------------------------
Component/s: Core
> Add RandomPartitioner based system tests
> ----------------------------------------
>
> Key: CASSANDRA-1140
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1140
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jeremy Hanna
> Assignee: Jeremy Hanna
> Priority: Minor
>
> Currently all of the system tests use the CollatingOrderPreservingPartitioner, likely because it has capabilities that the RandomPartitioner does not.
> It would be nice if there were a separate set of tests for things specific to the RandomPartitioner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1140) Add RandomPartitioner based system
tests
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Hanna updated CASSANDRA-1140:
------------------------------------
Attachment: cassandra-1040-patch.txt
Updated the patch to have the rp_tester method use a ThriftRPTester instead of a ThriftTester.
> Add RandomPartitioner based system tests
> ----------------------------------------
>
> Key: CASSANDRA-1140
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1140
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jeremy Hanna
> Assignee: Jeremy Hanna
> Priority: Minor
> Attachments: cassandra-1040-patch.txt
>
>
> Currently all of the system tests use the CollatingOrderPreservingPartitioner, likely because it has capabilities that the RandomPartitioner does not.
> It would be nice if there were a separate set of tests for things specific to the RandomPartitioner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1140) Add RandomPartitioner based
system tests
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877658#action_12877658 ]
Jonathan Ellis commented on CASSANDRA-1140:
-------------------------------------------
python's dynamic enough that you should be able to just say "from tests import class1, class2, class3, ..." in both test_thrift_server and test_thrift_random_server. then only the tests that give different results on different partitioners, would be in the partitioner-specific test file.
> Add RandomPartitioner based system tests
> ----------------------------------------
>
> Key: CASSANDRA-1140
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1140
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jeremy Hanna
> Assignee: Jeremy Hanna
> Priority: Minor
> Attachments: cassandra-1040-patch.txt
>
>
> Currently all of the system tests use the CollatingOrderPreservingPartitioner, likely because it has capabilities that the RandomPartitioner does not.
> It would be nice if there were a separate set of tests for things specific to the RandomPartitioner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1140) Add RandomPartitioner based
system tests
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875779#action_12875779 ]
Jonathan Ellis commented on CASSANDRA-1140:
-------------------------------------------
i'd really rather structure this so we're not copy/pasting so much, but i don't know enough about nose to say what the best way to do this is.
> Add RandomPartitioner based system tests
> ----------------------------------------
>
> Key: CASSANDRA-1140
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1140
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jeremy Hanna
> Assignee: Jeremy Hanna
> Priority: Minor
> Attachments: cassandra-1040-patch.txt
>
>
> Currently all of the system tests use the CollatingOrderPreservingPartitioner, likely because it has capabilities that the RandomPartitioner does not.
> It would be nice if there were a separate set of tests for things specific to the RandomPartitioner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1140) Add RandomPartitioner based
system tests
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875788#action_12875788 ]
Jeremy Hanna commented on CASSANDRA-1140:
-----------------------------------------
I wasn't sure how to do that better - I'm just giving it an alternate cassandra_include directory, which has all of those configuration files in it.
I didn't think there was a better solution because that's the most granular extension point afaik.
With the structure of the directories though maybe there's a cleaner way if we're planning on having a set of tests for each partitioner or something.
> Add RandomPartitioner based system tests
> ----------------------------------------
>
> Key: CASSANDRA-1140
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1140
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jeremy Hanna
> Assignee: Jeremy Hanna
> Priority: Minor
> Attachments: cassandra-1040-patch.txt
>
>
> Currently all of the system tests use the CollatingOrderPreservingPartitioner, likely because it has capabilities that the RandomPartitioner does not.
> It would be nice if there were a separate set of tests for things specific to the RandomPartitioner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1140) Add RandomPartitioner based system
tests
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Hanna updated CASSANDRA-1140:
------------------------------------
Attachment: (was: cassandra-1040-patch.txt)
> Add RandomPartitioner based system tests
> ----------------------------------------
>
> Key: CASSANDRA-1140
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1140
> Project: Cassandra
> Issue Type: Test
> Components: Core
> Reporter: Jeremy Hanna
> Assignee: Jeremy Hanna
> Priority: Minor
> Attachments: cassandra-1040-patch.txt
>
>
> Currently all of the system tests use the CollatingOrderPreservingPartitioner, likely because it has capabilities that the RandomPartitioner does not.
> It would be nice if there were a separate set of tests for things specific to the RandomPartitioner.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.