You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "srkreddy1238 (via GitHub)" <gi...@apache.org> on 2023/02/15 11:31:51 UTC
[GitHub] [tvm] srkreddy1238 opened a new pull request, #14000: [DOCKER] Configurable NDK version support
srkreddy1238 opened a new pull request, #14000:
URL: https://github.com/apache/tvm/pull/14000
Let the Android NDK version configurable as a command line argument
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #14000: [DOCKER] Configurable NDK version support
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14000:
URL: https://github.com/apache/tvm/pull/14000#issuecomment-1431224827
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to tag found in teams: `docker` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev commented on a diff in pull request #14000: [DOCKER] Configurable NDK version support
Posted by "echuraev (via GitHub)" <gi...@apache.org>.
echuraev commented on code in PR #14000:
URL: https://github.com/apache/tvm/pull/14000#discussion_r1108033872
##########
docker/Dockerfile.ci_adreno:
##########
@@ -22,10 +22,10 @@ COPY utils/apt-install-and-clear.sh /usr/local/bin/apt-install-and-clear
# Android SDK
COPY install/ubuntu_install_androidsdk.sh /install/ubuntu_install_androidsdk.sh
-RUN bash /install/ubuntu_install_androidsdk.sh
+RUN bash /install/ubuntu_install_androidsdk.sh 25.2.9519653 25
ENV ANDROID_HOME=/opt/android-sdk-linux
-ENV ANDROID_NDK_HOME=/opt/android-sdk-linux/ndk/21.3.6528147
-ENV ANDROID_NDK_MAJOR=21
+ENV ANDROID_NDK_HOME=/opt/android-sdk-linux/ndk/25.2.9519653
+ENV ANDROID_NDK_MAJOR=25
Review Comment:
Is it necessary to specify these variables here? I see that they will be added to `/etc/profile` in `ubuntu_install_androidsdk.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev commented on a diff in pull request #14000: [DOCKER] Configurable NDK version support
Posted by "echuraev (via GitHub)" <gi...@apache.org>.
echuraev commented on code in PR #14000:
URL: https://github.com/apache/tvm/pull/14000#discussion_r1108469409
##########
docker/Dockerfile.ci_adreno:
##########
@@ -22,10 +22,7 @@ COPY utils/apt-install-and-clear.sh /usr/local/bin/apt-install-and-clear
# Android SDK
COPY install/ubuntu_install_androidsdk.sh /install/ubuntu_install_androidsdk.sh
-RUN bash /install/ubuntu_install_androidsdk.sh
-ENV ANDROID_HOME=/opt/android-sdk-linux
-ENV ANDROID_NDK_HOME=/opt/android-sdk-linux/ndk/21.3.6528147
-ENV ANDROID_NDK_MAJOR=21
+RUN bash /install/ubuntu_install_androidsdk.sh 25.2.9519653 25
Review Comment:
Sorry, one more comment. Probably we shouldn't pass `ANDROID_NDK_MAJOR`? We can parse this value from `ANDROID_NDK_VERSION`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] srkreddy1238 commented on a diff in pull request #14000: [DOCKER] Configurable NDK version support
Posted by "srkreddy1238 (via GitHub)" <gi...@apache.org>.
srkreddy1238 commented on code in PR #14000:
URL: https://github.com/apache/tvm/pull/14000#discussion_r1108874369
##########
docker/Dockerfile.ci_adreno:
##########
@@ -22,10 +22,7 @@ COPY utils/apt-install-and-clear.sh /usr/local/bin/apt-install-and-clear
# Android SDK
COPY install/ubuntu_install_androidsdk.sh /install/ubuntu_install_androidsdk.sh
-RUN bash /install/ubuntu_install_androidsdk.sh
-ENV ANDROID_HOME=/opt/android-sdk-linux
-ENV ANDROID_NDK_HOME=/opt/android-sdk-linux/ndk/21.3.6528147
-ENV ANDROID_NDK_MAJOR=21
+RUN bash /install/ubuntu_install_androidsdk.sh 25.2.9519653 25
Review Comment:
Done. Made few other tools versions too configurable. Cmake was causing some warnings over older version with new NDK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev merged pull request #14000: [DOCKER] Configurable NDK version support
Posted by "echuraev (via GitHub)" <gi...@apache.org>.
echuraev merged PR #14000:
URL: https://github.com/apache/tvm/pull/14000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org