[jira] [Commented] (FLINK-9059) Add support for unified table source and sink declaration in environment file

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423631#comment-16423631 ] 

ASF GitHub Bot commented on FLINK-9059:
---------------------------------------

GitHub user suez1224 reopened a pull request:

    https://github.com/apache/flink/pull/5758

    [FLINK-9059][Table API & SQL] add table type attribute; replace "sources" with "tables" in environm…

    ## What is the purpose of the change
    
    Add support for unified table source and sink declaration in environment file definition.
    This change prepares for FLINK-9049 (Create unified interfaces to configure and instatiate TableSink) We want to get this change in before 1.5 so it wont break the API in next flink release.
    
    
    ## Brief change log
    
      - Refactor sql client environment file definition to replace "sources" with "tables" 
      - Add "type" property to distinguish between table source and sink.
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as *(please describe tests)*.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): ( no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: ( no )
      - The runtime per-record code paths (performance sensitive): (no )
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/suez1224/flink FLINK-9059

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5758.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5758
    
----
commit 7886287edd464c4a9fc84a47be214ff39b8e5ad0
Author: Shuyi Chen <sh...@...>
Date:   2018-03-23T06:00:00Z

    add table type attribute; replace "sources" with "tables" in environment file

commit 63a3faa115254564cb5fb8e85f0e0e50e33062fe
Author: Shuyi Chen <sh...@...>
Date:   2018-03-30T17:12:10Z

    fix comments

----


> Add support for unified table source and sink declaration in environment file
> -----------------------------------------------------------------------------
>
>                 Key: FLINK-9059
>                 URL: https://issues.apache.org/jira/browse/FLINK-9059
>             Project: Flink
>          Issue Type: Task
>          Components: Table API &amp; SQL
>            Reporter: Shuyi Chen
>            Assignee: Shuyi Chen
>            Priority: Major
>             Fix For: 1.5.0
>
>
> 1) Add a common property called "type" with single value 'source'.
> 2) in yaml file, replace "sources" with "tables".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)