You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2014/10/15 18:24:11 UTC
Review Request 26754: Slider Wizard, step 3, add property modal error
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26754/
-----------------------------------------------------------
Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
Bugs: AMBARI-7790
https://issues.apache.org/jira/browse/AMBARI-7790
Repository: ambari
Description
-------
Add-property modal shouldn't hide after click "Add" if some errors with new config.
Diffs
-----
contrib/views/slider/src/main/resources/ui/app/components/configSection.js a1608d2
contrib/views/slider/src/main/resources/ui/app/templates/components/configSection.hbs 326218a
contrib/views/slider/src/main/resources/ui/test/integration/processes/create_new_app_test.js 361db08
Diff: https://reviews.apache.org/r/26754/diff/
Testing
-------
Tests completed in 6216 milliseconds.
102 assertions of 102 passed, 0 failed.
Thanks,
Oleg Nechiporenko
Re: Review Request 26754: Slider Wizard, step 3,
add property modal error
Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26754/#review56728
-----------------------------------------------------------
Ship it!
Ship It!
- Andriy Babiichuk
On Окт. 15, 2014, 4:24 п.п., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26754/
> -----------------------------------------------------------
>
> (Updated Окт. 15, 2014, 4:24 п.п.)
>
>
> Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-7790
> https://issues.apache.org/jira/browse/AMBARI-7790
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add-property modal shouldn't hide after click "Add" if some errors with new config.
>
>
> Diffs
> -----
>
> contrib/views/slider/src/main/resources/ui/app/components/configSection.js a1608d2
> contrib/views/slider/src/main/resources/ui/app/templates/components/configSection.hbs 326218a
> contrib/views/slider/src/main/resources/ui/test/integration/processes/create_new_app_test.js 361db08
>
> Diff: https://reviews.apache.org/r/26754/diff/
>
>
> Testing
> -------
>
> Tests completed in 6216 milliseconds.
> 102 assertions of 102 passed, 0 failed.
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 26754: Slider Wizard, step 3,
add property modal error
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26754/#review56718
-----------------------------------------------------------
Ship it!
Ship It!
- Andrii Tkach
On Окт. 15, 2014, 4:24 п.п., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26754/
> -----------------------------------------------------------
>
> (Updated Окт. 15, 2014, 4:24 п.п.)
>
>
> Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-7790
> https://issues.apache.org/jira/browse/AMBARI-7790
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add-property modal shouldn't hide after click "Add" if some errors with new config.
>
>
> Diffs
> -----
>
> contrib/views/slider/src/main/resources/ui/app/components/configSection.js a1608d2
> contrib/views/slider/src/main/resources/ui/app/templates/components/configSection.hbs 326218a
> contrib/views/slider/src/main/resources/ui/test/integration/processes/create_new_app_test.js 361db08
>
> Diff: https://reviews.apache.org/r/26754/diff/
>
>
> Testing
> -------
>
> Tests completed in 6216 milliseconds.
> 102 assertions of 102 passed, 0 failed.
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 26754: Slider Wizard, step 3,
add property modal error
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26754/#review56716
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On Жов. 15, 2014, 4:24 після полудня, Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26754/
> -----------------------------------------------------------
>
> (Updated Жов. 15, 2014, 4:24 після полудня)
>
>
> Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-7790
> https://issues.apache.org/jira/browse/AMBARI-7790
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add-property modal shouldn't hide after click "Add" if some errors with new config.
>
>
> Diffs
> -----
>
> contrib/views/slider/src/main/resources/ui/app/components/configSection.js a1608d2
> contrib/views/slider/src/main/resources/ui/app/templates/components/configSection.hbs 326218a
> contrib/views/slider/src/main/resources/ui/test/integration/processes/create_new_app_test.js 361db08
>
> Diff: https://reviews.apache.org/r/26754/diff/
>
>
> Testing
> -------
>
> Tests completed in 6216 milliseconds.
> 102 assertions of 102 passed, 0 failed.
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>