Re: [PR] [test] Move gzip helper from core production code to hive test [paimon]

["JingsongLi (via GitHub)" <gi...@apache.org>]

JingsongLi commented on code in PR #8396:
URL: https://github.com/apache/paimon/pull/8396#discussion_r3503025418


##########
paimon-hive/paimon-hive-connector-common/src/test/java/org/apache/paimon/hive/HiveCatalogFormatTableITCaseBase.java:
##########
@@ -274,4 +277,16 @@ protected List<Row> collect(String sql) throws Exception {
         }
         return result;
     }
+
+    private static void gzipCompressFile(String src, String dest) throws IOException {

Review Comment:
   Making this helper local to the Hive test leaves another caller broken. `paimon-spark/paimon-spark-ut/src/test/scala/org/apache/paimon/spark/sql/FormatTableTestBase.scala` still imports `org.apache.paimon.utils.CompressUtils` and calls `CompressUtils.gzipCompressFile`, so deleting the core class will make the Spark test module fail to compile. Please either move the helper to a shared test utility used by both modules, or update the Spark test to use its own/local helper as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org