You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/01/04 10:23:05 UTC
Review Request 41872: Used only exactly representable floats in test
calculation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41872/
-----------------------------------------------------------
Review request for mesos, Alexander Rojas and Michael Park.
Bugs: MESOS-4272
https://issues.apache.org/jira/browse/MESOS-4272
Repository: mesos
Description
-------
yIn the IEEE floating point standard representation usually only values
where the fractional part of the normalized form is a multiple of 2^n
can be represented exactly; a value of 0.33 cannot be represented
exactly. This can lead to an incorrectly failing tests where the
calculated value does not match the expectation.
Instead switch to a value of 0.25 which can be represented exactly.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp 0aafc8643cf6afcb58befa6c1e7d427ac529be03
Diff: https://reviews.apache.org/r/41872/diff/
Testing
-------
Thanks,
Benjamin Bannier
Re: Review Request 41872: Used only exactly representable floats in
test calculation.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41872/#review112564
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Jan. 4, 2016, 9:23 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41872/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 9:23 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-4272
> https://issues.apache.org/jira/browse/MESOS-4272
>
>
> Repository: mesos
>
>
> Description
> -------
>
> yIn the IEEE floating point standard representation usually only values
> where the fractional part of the normalized form is a multiple of 2^n
> can be represented exactly; a value of 0.33 cannot be represented
> exactly. This can lead to an incorrectly failing tests where the
> calculated value does not match the expectation.
>
> Instead switch to a value of 0.25 which can be represented exactly.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp 0aafc8643cf6afcb58befa6c1e7d427ac529be03
>
> Diff: https://reviews.apache.org/r/41872/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 41872: Used only exactly representable floats in
test calculation.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41872/#review112547
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Jan. 4, 2016, 10:23 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41872/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 10:23 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Michael Park.
>
>
> Bugs: MESOS-4272
> https://issues.apache.org/jira/browse/MESOS-4272
>
>
> Repository: mesos
>
>
> Description
> -------
>
> yIn the IEEE floating point standard representation usually only values
> where the fractional part of the normalized form is a multiple of 2^n
> can be represented exactly; a value of 0.33 cannot be represented
> exactly. This can lead to an incorrectly failing tests where the
> calculated value does not match the expectation.
>
> Instead switch to a value of 0.25 which can be represented exactly.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp 0aafc8643cf6afcb58befa6c1e7d427ac529be03
>
> Diff: https://reviews.apache.org/r/41872/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>