You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by bowenli86 <gi...@git.apache.org> on 2017/10/22 16:28:48 UTC

[GitHub] flink pull request #4882: [FLINK-6245] Fix late side output documentation in...

GitHub user bowenli86 opened a pull request:

    https://github.com/apache/flink/pull/4882

    [FLINK-6245] Fix late side output documentation in Window documents.

    ## What is the purpose of the change
    
    There are two things that need to be done:
    
    1) in the syntax description in the beginning of the page, we should also include the {{getSideOutput()}}
    
    2) in the "Getting late data as a side output" section and for the Java example, it should not be a {{DataStream<T> result ...}} but a {{SingleOutputStreamOperator}}, if we want to get the late event side output.
    
    ## Brief change log
    
    Fix docs
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
    none
    
    ## Documentation
    
    none
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bowenli86/flink FLINK-6245

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4882.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4882
    
----
commit 9a094341be894dd3f37a7fe4eaf126172b0c8dd7
Author: Bowen Li <bo...@gmail.com>
Date:   2017-10-22T16:27:09Z

    [FLINK-6245] Fix late side output documentation in Window documents.

----


---

[GitHub] flink issue #4882: [FLINK-6245] [doc] Fix late side output documentation in ...

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/4882
  
    Thanks for fixing this! 😃 
    
    Could you please close the PR?


---

[GitHub] flink pull request #4882: [FLINK-6245] [doc] Fix late side output documentat...

Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 closed the pull request at:

    https://github.com/apache/flink/pull/4882


---