You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jeff Trawick <tr...@gmail.com> on 2008/04/10 15:38:21 UTC

folks avoiding link error in mod_auth_form, or it links for you?

I need this to build trunk:

Index: modules/aaa/mod_auth_form.c
===================================================================
--- modules/aaa/mod_auth_form.c (revision 646781)
+++ modules/aaa/mod_auth_form.c (working copy)
@@ -498,9 +498,9 @@
     }

     ap_session_load_fn(r, &z);
-    ap_session_set(r, z, apr_pstrcat(r->pool, authname, "-"
MOD_SESSION_USER, NULL), user);
-    ap_session_set(r, z, apr_pstrcat(r->pool, authname, "-"
MOD_SESSION_PW, NULL), pw);
-    ap_session_set(r, z, apr_pstrcat(r->pool, authname, "-"
MOD_AUTH_FORM_HASH, NULL), hash);
+    ap_session_set_fn(r, z, apr_pstrcat(r->pool, authname, "-"
MOD_SESSION_USER, NULL), user);
+    ap_session_set_fn(r, z, apr_pstrcat(r->pool, authname, "-"
MOD_SESSION_PW, NULL), pw);
+    ap_session_set_fn(r, z, apr_pstrcat(r->pool, authname, "-"
MOD_AUTH_FORM_HASH, NULL), hash);

     return APR_SUCCESS;

@@ -518,13 +518,13 @@
     ap_session_load_fn(r, &z);

     if (user) {
-        ap_session_get(r, z, apr_pstrcat(r->pool, authname, "-"
MOD_SESSION_USER, NULL), user);
+        ap_session_get_fn(r, z, apr_pstrcat(r->pool, authname, "-"
MOD_SESSION_USER, NULL), user);
     }
     if (pw) {
-        ap_session_get(r, z, apr_pstrcat(r->pool, authname, "-"
MOD_SESSION_PW, NULL), pw);
+        ap_session_get_fn(r, z, apr_pstrcat(r->pool, authname, "-"
MOD_SESSION_PW, NULL), pw);
     }
     if (hash) {
-        ap_session_get(r, z, apr_pstrcat(r->pool, authname, "-"
MOD_AUTH_FORM_HASH, NULL), hash);
+        ap_session_get_fn(r, z, apr_pstrcat(r->pool, authname, "-"
MOD_AUTH_FORM_HASH, NULL), hash);
     }

     return APR_SUCCESS;

Why nobody else?

Re: folks avoiding link error in mod_auth_form, or it links for you?

Posted by Jeff Trawick <tr...@gmail.com>.
On Thu, Apr 10, 2008 at 9:46 AM, Graham Leggett <mi...@sharp.fm> wrote:

>  Could it be because you've included mod_auth_form, but not included
> mod_session?

I used the default configure setting for each.  Looking now, I have
mod_auth_form but not mod_auth_session.  So the default inclusion
rules may be the only problem to fix.

$ ./httpd -l | egrep '(form|session)'
  mod_auth_form.c

Re: folks avoiding link error in mod_auth_form, or it links for you?

Posted by Graham Leggett <mi...@sharp.fm>.
Jeff Trawick wrote:

> I need this to build trunk:

> Why nobody else?

Could it be because you've included mod_auth_form, but not included 
mod_session?

mod_session may need to export itself using optional functions, will 
take a look.

Regards,
Graham
--