You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/27 04:16:30 UTC

[GitHub] [cloudstack] miklosbarabas opened a new pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

miklosbarabas opened a new pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099


   - upgrade to support newer algorithms
   
   ## Description
   CloudStack is using the trilead-ssh2 library for ssh communications, but doesn't have support for the latest MAC algorithms, which can be a blocker of adopting Cloudstack for certain companies with more strict security requirements.
   
   The issue with the current version of trilead-ssh2 is that it is only supporting older MAC algorithms, so if one would like to add a hypervisor host to a cluster and the host runs a sshd with old algos excluded, it will be unable to add the host.
   
   There's a forked version of trilead-ssh2 which is still being maintained.
   Upgrade to this fork/version of trilead-ssh2 would provide the possibility to use newer algorithms for SSH without the need to touch actual business logic. 
   
   Resolves https://github.com/apache/cloudstack/issues/3255
   
   <!--- Describe your changes in detail -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Dajeong-Park commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
Dajeong-Park commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-858356017


   Same as above, I checked the error when building in centOS 8.4 environment.
   
   [ERROR] Failed to execute goal on project cloud-utils: Could not resolve dependencies for project org.apache.cloudstack:cloud-utils:jar:4.16.0.0-SNAPSHOT: Failed to collect dependencies at org.jenkins-ci:trilead-ssh2:jar:build-217-jenkins-27: Failed to read artifact descriptor for org.jenkins-ci:trilead-ssh2:jar:build-217-jenkins-27: Could not transfer artifact org.jenkins-ci:trilead-ssh2:pom:build-217-jenkins-27 from/to repo.jenkins-ci.org.releases (http://repo.jenkins-ci.org/releases/): Transfer failed for http://repo.jenkins-ci.org/releases/org/jenkins-ci/trilead-ssh2/build-217-jenkins-27/trilead-ssh2-build-217-jenkins-27.pom 308 Permanent Redirect -> [Help 1]
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-764799814


   Looks like the original authors are not working on it, but I see this repo https://github.com/jenkinsci/trilead-ssh2


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on a change in pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#discussion_r441244282



##########
File path: pom.xml
##########
@@ -164,7 +164,7 @@
         <cs.servicemix.version>3.3.3_1</cs.servicemix.version>
         <cs.servlet.version>4.0.1</cs.servlet.version>
         <cs.tomcat-embed-core.version>8.5.47</cs.tomcat-embed-core.version>
-        <cs.trilead.version>1.0.0-build222</cs.trilead.version>
+        <cs.trilead.version>trilead-ssh2-build-217-jenkins-17</cs.trilead.version>

Review comment:
       One issue it seems Jenkins forked the build-217 than latest build-222




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd closed pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-813884866


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-764798451


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-813866066


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-858358029


   @RodrigoDLopez @Dajeong-Park are you using 4.15 or master branch? Can you try updating the jenkins repo url to use https, as in https://github.com/apache/cloudstack/commit/f1c83a0b05844fce21e1ba8af31831773ddf239e 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-712770634


   @rhtyd do you consider that a blocker? (or..?)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-634410459






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] miklosbarabas commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
miklosbarabas commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-633623115


   @DaanHoogland 
   Actually the change is done, just wanted to add a test to cover this (that's why the PR was WIP), but didn't find an easy way of doing it. Any thoughts?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-858370360


   Alright @Dajeong-Park I'll cherry-pick the fix from master and get it on 4.15.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] Dajeong-Park commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
Dajeong-Park commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-858364739


   It is being used as a forked source by reflecting the merged sources in real time, and the build was successful by changing to https. Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-634835149


   <b>Trillian test result (tid-1570)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 46677 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4099-t1570-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Smoke tests completed. 83 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-813978836


   @rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] miklosbarabas closed pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
miklosbarabas closed pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-813884709


   @blueorangutan package
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-764798451






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-720329879


   Moving this to 4.16.0.0 milestone, any kind of major dependency change should be avoided as we're in code freeze. The workaround has been documented in the 4.15 release notes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-634418174


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-634410351


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-858609859


   @RodrigoDLopez the issue was recently fixed in 4.15,I've backported the commit to 4.15. Pl try using latest 4.15, if still hit the issue raise a PR thnx. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd closed pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-814455957


   <b>Trillian test result (tid-359)</b>
   Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 41883 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4099-t359-xenserver-71.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 83 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 85.20 | test_kubernetes_clusters.py
   test_01_scale_vm | `Failure` | 11.27 | test_scale_vm.py
   test_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 305.89 | test_host_maintenance.py
   test_02_cancel_host_maintenace_with_migration_jobs | `Failure` | 305.97 | test_host_maintenance.py
   test_03_cancel_host_maintenace_with_migration_jobs_failure | `Failure` | 0.20 | test_host_maintenance.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-764810764


   > Looks like the original authors are not working on it, but I see this repo https://github.com/jenkinsci/trilead-ssh2
   
   jenkinci/trilead-ssh2 looks better.
   
   I tested both few days ago. both do not work on ubuntu 20.04. it might be related to new openssh version.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-813865738


   @blueorangutan package 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-857709846


   hey folks, after this merge i'm facing troubles to build my own branches.
   somehow the maven are saying that the `repo` doesn't exist.
   To fix this I need to change the `pom.xml` from utils project.
   Am I doing something wrong?
   this is the error i receive:
   
   `
   [ERROR] Failed to execute goal on project cloud-utils: Could not resolve dependencies for project org.apache.cloudstack:cloud-utils:jar:4.15.1.0-SNAPSHOT: Failed to collect dependencies at org.jenkins-ci:trilead-ssh2:jar:build-217-jenkins-27: Failed to read artifact descriptor for org.jenkins-ci:trilead-ssh2:jar:build-217-jenkins-27: Could not transfer artifact org.jenkins-ci:trilead-ssh2:pom:build-217-jenkins-27 from/to repo.jenkins-ci.org.releases (http://repo.jenkins-ci.org/releases/): Transfer failed for http://repo.jenkins-ci.org/releases/org/jenkins-ci/trilead-ssh2/build-217-jenkins-27/trilead-ssh2-build-217-jenkins-27.pom 308 Permanent Redirect -> [Help 1]
   `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] RodrigoDLopez commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
RodrigoDLopez commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-858602941


   > @RodrigoDLopez @Dajeong-Park are you using 4.15 or master branch? Can you try updating the jenkins repo url to use https, as in [f1c83a0](https://github.com/apache/cloudstack/commit/f1c83a0b05844fce21e1ba8af31831773ddf239e)
   
   I tried one of my own branches, and then i tried with 4.15. same error into both branches. I'm using the last maven version
   
   > It is being used as a forked source by reflecting the merged sources in real time, and the build was successful by changing to https. Thank you.
   
   @rhtyd as @Dajeong-Park said. 
   we need to change the pom.xml in order to successfully build the project.
   
   Can I do a small PR to fix this in 4.15?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-814426239


   <b>Trillian test result (tid-360)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37268 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4099-t360-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 84 look OK, 2 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 76.54 | test_kubernetes_clusters.py
   test_01_migrate_VM_and_root_volume | `Error` | 70.44 | test_vm_life_cycle.py
   test_02_migrate_VM_with_two_data_disks | `Error` | 48.30 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-813920133


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 334


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-813868025


   @miklosbarabas I've updated the jar dependency to latest version, can you check and test if it works for your env? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-634417870


   @blueorangutan test 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-764838449


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2569


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-813978344


   @blueorangutan test matrix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-814623266


   Comparing against baseline 4.15 health check PR, don't see any new failures. LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-633647972


   @miklosbarabas, I suppose you could call `protected static boolean canEndTheSshConnection(int waitResultTimeoutInMs, com.trilead.ssh2.Session sess, int conditions) throws SshException, InterruptedException` in a test that should throw an `InterruptedException`. I am not entirely sure why you need this change but I'm sure either a unit test or an integration test must be possible for it.
   converting it back to draft for now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-764810764


   > Looks like the original authors are not working on it, but I see this repo https://github.com/jenkinsci/trilead-ssh2
   
   jenkinci/trilead-ssh2 looks better.
   
   I tested both few days ago. both do not work on ubuntu 20.04. it might be related to new openssh version.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] shwstppr commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-783255318


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-764798993


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-764798993






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4099: using forked version of trilead-ssh2 (from org.jenkins-ci)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4099:
URL: https://github.com/apache/cloudstack/pull/4099#issuecomment-814418907


   <b>Trillian test result (tid-361)</b>
   Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36771 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4099-t361-vmware-65u2.zip
   Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Smoke tests completed. 83 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_10_traceroute_in_vr | `Failure` | 61.26 | test_diagnostics.py
   test_01_deploy_kubernetes_cluster | `Failure` | 107.15 | test_kubernetes_clusters.py
   test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 61.93 | test_kubernetes_clusters.py
   test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 61.51 | test_kubernetes_clusters.py
   test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 98.35 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 64.91 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 87.08 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 87.75 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 80.03 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 123.87 | test_kubernetes_clusters.py
   ContextSuite context=TestVAppsVM>:setup | `Error` | 43.85 | test_vm_life_cycle.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org