[GitHub] [orc] belugabehr commented on a change in pull request #702: ORC-801: Clean up Logging

[GitBox <gi...@apache.org>]

belugabehr commented on a change in pull request #702:
URL: https://github.com/apache/orc/pull/702#discussion_r642098226



##########
File path: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java
##########
@@ -1030,13 +1026,11 @@ public SargApplier(SearchArgument sarg,
                   LOG.info("Skipping ORC PPD - " + e.getMessage() + " on "
                       + predicate);
                 } else {
-                  if (LOG.isWarnEnabled()) {
-                    final String reason = e.getClass().getSimpleName() + " when evaluating predicate." +
-                        " Skipping ORC PPD." +
-                        " Stats: " + stats +
-                        " Predicate: " + predicate;
-                    LOG.warn(reason, e);
-                  }
+                  final String reason = e.getClass().getSimpleName() + " when evaluating predicate." +
+                      " Skipping ORC PPD." +
+                      " Stats: " + stats +
+                      " Predicate: " + predicate;
+                  LOG.warn(reason, e);

Review comment:
       Hello. This change is intentional.  There is never a reason to wrap a `warn` level message in logging guards: `isWarnEnabled`.  The answer will always be "true"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org