You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/06 08:40:03 UTC
[GitHub] [doris] xy720 opened a new pull request, #10649: [BugFix](Array)Fix using Array aggregate function caused be coredump
xy720 opened a new pull request, #10649:
URL: https://github.com/apache/doris/pull/10649
# Proposed changes
Issue Number: close #10648
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] qidaye commented on pull request #10649: [BugFix](Array)Fix using Array aggregate function caused be coredump
Posted by GitBox <gi...@apache.org>.
qidaye commented on PR #10649:
URL: https://github.com/apache/doris/pull/10649#issuecomment-1177004292
This bug is similar to #10640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10649: [BugFix](Array)Fix using Array aggregate function caused be coredump
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10649:
URL: https://github.com/apache/doris/pull/10649#issuecomment-1186761111
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xy720 commented on pull request #10649: [BugFix](Array)Fix using Array aggregate function caused be coredump
Posted by GitBox <gi...@apache.org>.
xy720 commented on PR #10649:
URL: https://github.com/apache/doris/pull/10649#issuecomment-1177014757
> This bug is similar to #10640
I think it is not the same bug.
This bug is because the `convert_to_full_column_if_const` function has never been called in advance.
But in #10640, the bug is caused by the memory space return by `convert_to_full_column_if_const` was released in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10649: [BugFix](Array)Fix using Array aggregate function caused be coredump
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10649:
URL: https://github.com/apache/doris/pull/10649#issuecomment-1177003874
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] qidaye commented on pull request #10649: [BugFix](Array)Fix using Array aggregate function caused be coredump
Posted by GitBox <gi...@apache.org>.
qidaye commented on PR #10649:
URL: https://github.com/apache/doris/pull/10649#issuecomment-1177032628
> > This bug is similar to #10640
>
> I think it is not the same bug. This bug is because the `convert_to_full_column_if_const` function has never been called in advance.
>
> But in #10640, the bug is caused by the memory space return by `convert_to_full_column_if_const` was released in advance.
>
> > > This bug is similar to #10640
> >
> >
> > I think it is not the same bug. This bug is because the `convert_to_full_column_if_const` function has never been called in advance.
> > But in #10640, the bug is caused by the memory space return by `convert_to_full_column_if_const` was released in advance.
>
> Haha, but they do look like same.
Yes. Not same bug, but similar way to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xy720 merged pull request #10649: [BugFix](Array)Fix using Array aggregate function caused be coredump
Posted by GitBox <gi...@apache.org>.
xy720 merged PR #10649:
URL: https://github.com/apache/doris/pull/10649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10649: [BugFix](Array)Fix using Array aggregate function caused be coredump
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10649:
URL: https://github.com/apache/doris/pull/10649#issuecomment-1177003900
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xy720 commented on pull request #10649: [BugFix](Array)Fix using Array aggregate function caused be coredump
Posted by GitBox <gi...@apache.org>.
xy720 commented on PR #10649:
URL: https://github.com/apache/doris/pull/10649#issuecomment-1177016870
> This bug is similar to #10640
I think it is not the same bug.
This bug is because the `convert_to_full_column_if_const` function has never been called in advance.
But in #10640, the bug is caused by the memory space return by `convert_to_full_column_if_const` was released in advance.
> > This bug is similar to #10640
>
> I think it is not the same bug. This bug is because the `convert_to_full_column_if_const` function has never been called in advance.
>
> But in #10640, the bug is caused by the memory space return by `convert_to_full_column_if_const` was released in advance.
Haha, but they do look like same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org