You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Koji Noguchi (JIRA)" <ji...@apache.org> on 2008/04/05 01:48:24 UTC
[jira] Created: (HADOOP-3186) Incorrect permission checking on mv
Incorrect permission checking on mv
------------------------------------
Key: HADOOP-3186
URL: https://issues.apache.org/jira/browse/HADOOP-3186
Project: Hadoop Core
Issue Type: Bug
Components: dfs
Affects Versions: 0.16.2
Environment: permission turned on
Reporter: Koji Noguchi
{noformat}
/data <dir> 2008-04-04 00:47 rwxr-xr-x root users
/data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
/user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
[knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":roort:users:rwxr-xr-x
{noformat}
Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3186) Incorrect permission checking on mv
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3186:
-------------------------------------------
Attachment: 3186_20080418c.patch
3186_20080418c.patch: here is a new one, suggested by Raghu.
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch, 3186_20080418c.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3186) Incorrect permission checking on
mv
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585854#action_12585854 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-3186:
------------------------------------------------
Got a different behavior in truck but the bug is still there.
{noformat}
/user/tsz/koji <dir> 2008-04-04 17:14 rwxr-xr-x nn_sze supergroup
/user/tsz/koji/k <dir> 2008-04-04 17:11 rwxr-xr-x tsz supergroup
/user/tsz/koji/k/test <dir> 2008-04-04 17:11 rwxr-xr-x tsz supergroup
/user/tsz/koji/testdir <dir> 2008-04-04 17:14 rwxr-xr-x tsz supergroup
bash-3.2$ ./bin/hadoop dfs -mv koji/k/test koji/testdir
mv: null
{noformat}
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3186) Incorrect permission checking on mv
Posted by "Mukund Madhugiri (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mukund Madhugiri updated HADOOP-3186:
-------------------------------------
Fix Version/s: (was: 0.17.0)
0.16.4
I committed this to 0.16.4. Thanks Nicholas.
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.16.4
>
> Attachments: 3186_20080418b.patch, 3186_20080418c.patch, 3186_20080420.patch, 3186_20080420_0.16.patch, 3186_20080429_0.16.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3186) Incorrect permission checking on mv
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3186:
-------------------------------------------
Attachment: 3186_20080418b.patch
3186_20080418b.patch: corrected the rename permission checking
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3186) Incorrect permission checking on
mv
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590647#action_12590647 ]
Raghu Angadi commented on HADOOP-3186:
--------------------------------------
> We don't need to use Path.SEPERATOR. This is already in DFS. It is '/' (or DFS.seperator if one exists).
Oops. Path.SEPERATOR is our own constant. I though it might be platform dependent.
+1 for the patch. looks good.
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch, 3186_20080418c.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3186) Incorrect permission checking on
mv
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590799#action_12590799 ]
Hadoop QA commented on HADOOP-3186:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12380546/3186_20080418c.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 3 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests -1. The patch failed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2284/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2284/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2284/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2284/console
This message is automatically generated.
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch, 3186_20080418c.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3186) Incorrect permission checking on
mv
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590627#action_12590627 ]
Raghu Angadi commented on HADOOP-3186:
--------------------------------------
Can you describe what the permission checking policy for rename() is?
"-mv" is implemented by rename but not correctly. "mv file /dest" creates /dest/file if dest is a directly. but "rename(file, /dest)", will either fail or create /dest but will not /dest/file, right?
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3186) Incorrect permission checking on mv
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raghu Angadi updated HADOOP-3186:
---------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks Nicholas.
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch, 3186_20080418c.patch, 3186_20080420.patch, 3186_20080420_0.16.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3186) Incorrect permission checking on mv
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3186:
-------------------------------------------
Attachment: 3270_20080420.patch
3270_20080420.patch: fixed a bug.
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch, 3186_20080418c.patch, 3270_20080420.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3186) Incorrect permission checking on
mv
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590645#action_12590645 ]
Raghu Angadi commented on HADOOP-3186:
--------------------------------------
We don't need to use Path.SEPERATOR. This is already in DFS. It is '/' (or DFS.seperator if one exists).
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch, 3186_20080418c.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3186) Incorrect permission checking on mv
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-3186:
------------------------------------
Priority: Blocker (was: Major)
Fix Version/s: 0.17.0
Assignee: Tsz Wo (Nicholas), SZE
QA requested promotion.
Requires a patches suitable for both 0.17 and 0.16.3.
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3186) Incorrect permission checking on
mv
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590989#action_12590989 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-3186:
------------------------------------------------
3186_20080418c.patch changes FSDirectory. unprotectedRenameTo(...) but FSEditLog uses it. So it failed the tests. 3186_2008042 only changes the permission checking in FSNamesystem.renameToInternal(...).
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch, 3186_20080418c.patch, 3186_20080420.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3186) Incorrect permission checking on mv
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3186:
-------------------------------------------
Attachment: 3186_20080429_0.16.patch
3186_20080429_0.16.patch: sync with the code base
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch, 3186_20080418c.patch, 3186_20080420.patch, 3186_20080420_0.16.patch, 3186_20080429_0.16.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3186) Incorrect permission checking on mv
Posted by "Koji Noguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Koji Noguchi updated HADOOP-3186:
---------------------------------
Description:
{noformat}
/data <dir> 2008-04-04 00:47 rwxr-xr-x root users
/data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
/user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
[knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
{noformat}
Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
was:
{noformat}
/data <dir> 2008-04-04 00:47 rwxr-xr-x root users
/data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
/user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
[knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":roort:users:rwxr-xr-x
{noformat}
Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3186) Incorrect permission checking on mv
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3186:
-------------------------------------------
Attachment: (was: 3270_20080420.patch)
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch, 3186_20080418c.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3186) Incorrect permission checking on
mv
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590822#action_12590822 ]
Hadoop QA commented on HADOOP-3186:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12380586/3186_20080420.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 3 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2288/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2288/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2288/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2288/console
This message is automatically generated.
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch, 3186_20080418c.patch, 3186_20080420.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3186) Incorrect permission checking on mv
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3186:
-------------------------------------------
Attachment: 3186_20080420.patch
3270_20080420.patch => 3186_20080420.patch
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch, 3186_20080418c.patch, 3186_20080420.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3186) Incorrect permission checking on mv
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3186:
-------------------------------------------
Status: Open (was: Patch Available)
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch, 3186_20080418c.patch, 3270_20080420.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3186) Incorrect permission checking on
mv
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591372#action_12591372 ]
Hudson commented on HADOOP-3186:
--------------------------------
Integrated in Hadoop-trunk #467 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/467/])
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch, 3186_20080418c.patch, 3186_20080420.patch, 3186_20080420_0.16.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3186) Incorrect permission checking on mv
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3186:
-------------------------------------------
Attachment: 3186_20080420_0.16.patch
3186_20080420_0.16.patch: for 0.16
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch, 3186_20080418c.patch, 3186_20080420.patch, 3186_20080420_0.16.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3186) Incorrect permission checking on mv
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3186:
-------------------------------------------
Status: Patch Available (was: Open)
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3186) Incorrect permission checking on
mv
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590630#action_12590630 ]
Raghu Angadi commented on HADOOP-3186:
--------------------------------------
Ok, DFS.renameTo() is actually not a rename but a move. We should fix that separately.
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3186) Incorrect permission checking on
mv
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590994#action_12590994 ]
Raghu Angadi commented on HADOOP-3186:
--------------------------------------
+1.
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch, 3186_20080418c.patch, 3186_20080420.patch, 3186_20080420_0.16.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3186) Incorrect permission checking on mv
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3186:
-------------------------------------------
Status: Patch Available (was: Open)
> Incorrect permission checking on mv
> ------------------------------------
>
> Key: HADOOP-3186
> URL: https://issues.apache.org/jira/browse/HADOOP-3186
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Affects Versions: 0.16.2
> Environment: permission turned on
> Reporter: Koji Noguchi
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: 3186_20080418b.patch, 3186_20080418c.patch, 3270_20080420.patch
>
>
> {noformat}
> /data <dir> 2008-04-04 00:47 rwxr-xr-x root users
> /data/testdir <dir> 2008-04-04 23:44 rwxrwxrwx knoguchi users
> /user/knoguchi/test <dir> 2008-04-04 23:45 rwxrwxrwx knoguchi users
> [knoguchi]$ hadoop dfs -mv /user/knoguchi/test /data/testdir
> mv: org.apache.hadoop.fs.permission.AccessControlException: Permission denied: user=knoguchi, access=WRITE, inode="data":root:users:rwxr-xr-x
> {noformat}
> Since target directory, /data/testdir, exists, it should not check the permission of the parent directory
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.