[jira] [Commented] (FLUME-2994) flume-taildir-source: support for windows

["Bessenyei Balázs Donát (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLUME-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548366#comment-15548366 ] 

Bessenyei Balázs Donát commented on FLUME-2994:
-----------------------------------------------

[~jkushmaul]: thank you for the patch!

I'm not sure the fileKey.hashCode is as unique as we want it to be. 

Do you think we could change the tailFiles Map so that the keys would be the "FileKey"-s themselves? (Instead of using the hashcodes for inodes)

> flume-taildir-source: support for windows
> -----------------------------------------
>
>                 Key: FLUME-2994
>                 URL: https://issues.apache.org/jira/browse/FLUME-2994
>             Project: Flume
>          Issue Type: Improvement
>          Components: Sinks+Sources, Windows
>    Affects Versions: v1.7.0
>            Reporter: Jason Kushmaul
>            Assignee: Jason Kushmaul
>            Priority: Trivial
>             Fix For: v1.7.0
>
>         Attachments: FLUME-2994-2.patch, taildir-mac.conf, taildir-win8.1.conf
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> The current implementation of flume-taildir-source does not support windows.
> The only reason for this from what I can see is a simple call to Files.getAttribute(file.toPath(), "unix:ino");
> I've tested an equivalent for windows (which of course does not work on non-windows).  With an OS switch we should be able to identify a file independent of file name on either system.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)