You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/06/14 08:07:52 UTC
[GitHub] [calcite] devozerov opened a new pull request #2436: [CALCITE-4638] VolcanoPlanner fails to recognize transformation rule correctly in the top-down mode (Vladimir Ozerov)
devozerov opened a new pull request #2436:
URL: https://github.com/apache/calcite/pull/2436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] hsyuan merged pull request #2436: [CALCITE-4638] VolcanoPlanner fails to recognize transformation rule correctly in the top-down mode (Vladimir Ozerov)
Posted by GitBox <gi...@apache.org>.
hsyuan merged pull request #2436:
URL: https://github.com/apache/calcite/pull/2436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] zinking commented on a change in pull request #2436: [CALCITE-4638] VolcanoPlanner fails to recognize transformation rule correctly in the top-down mode (Vladimir Ozerov)
Posted by GitBox <gi...@apache.org>.
zinking commented on a change in pull request #2436:
URL: https://github.com/apache/calcite/pull/2436#discussion_r651684547
##########
File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
##########
@@ -1553,15 +1553,7 @@ protected boolean isSubstituteRule(VolcanoRuleCall match) {
*/
@API(since = "1.24", status = API.Status.EXPERIMENTAL)
protected boolean isTransformationRule(VolcanoRuleCall match) {
- if (match.getRule() instanceof SubstitutionRule) {
- return true;
- }
- if (match.getRule() instanceof ConverterRule
- && match.getRule().getOutTrait() == rootConvention) {
- return false;
- }
- return match.getRule().getOperand().trait == Convention.NONE
- || match.getRule().getOperand().trait == null;
+ return match.getRule() instanceof TransformationRule;
Review comment:
I can roughly grasp what is happening after reading the mail
can we add some comments here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org