You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/12/09 08:29:18 UTC
[GitHub] [iotdb] stormbroken opened a new pull request #4547: [IOTDB-1969] Remove old metric framework from iotdb-server
stormbroken opened a new pull request #4547:
URL: https://github.com/apache/iotdb/pull/4547
I remove old metric framework from iotdb-server, and all parameters about metric are in iotdb-metric.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] stormbroken commented on a change in pull request #4547: [IOTDB-1969] Remove old metric framework from iotdb-server
Posted by GitBox <gi...@apache.org>.
stormbroken commented on a change in pull request #4547:
URL: https://github.com/apache/iotdb/pull/4547#discussion_r765559306
##########
File path: server/src/main/java/org/apache/iotdb/db/service/thrift/impl/TSServiceImpl.java
##########
@@ -170,21 +93,12 @@
private static final String INFO_INTERRUPT_ERROR =
"Current Thread interrupted when dealing with request {}";
- private static final int MAX_SIZE = CONFIG.getQueryCacheSizeInMetric();
- private static final int DELETE_SIZE = 20;
-
- private static final List<SqlArgument> sqlArgumentList = new ArrayList<>(MAX_SIZE);
-
private long startTime = -1L;
Review comment:
Let me take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] stormbroken commented on a change in pull request #4547: [IOTDB-1969] Remove old metric framework from iotdb-server
Posted by GitBox <gi...@apache.org>.
stormbroken commented on a change in pull request #4547:
URL: https://github.com/apache/iotdb/pull/4547#discussion_r765561166
##########
File path: server/src/main/java/org/apache/iotdb/db/service/thrift/impl/TSServiceImpl.java
##########
@@ -170,21 +93,12 @@
private static final String INFO_INTERRUPT_ERROR =
"Current Thread interrupted when dealing with request {}";
- private static final int MAX_SIZE = CONFIG.getQueryCacheSizeInMetric();
- private static final int DELETE_SIZE = 20;
-
- private static final List<SqlArgument> sqlArgumentList = new ArrayList<>(MAX_SIZE);
-
private long startTime = -1L;
Review comment:
This parameters may used by tracing, so I can't delete this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4547: [IOTDB-1969] Remove old metric framework from iotdb-server
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4547:
URL: https://github.com/apache/iotdb/pull/4547#discussion_r765559008
##########
File path: server/src/main/java/org/apache/iotdb/db/service/thrift/impl/TSServiceImpl.java
##########
@@ -170,21 +93,12 @@
private static final String INFO_INTERRUPT_ERROR =
"Current Thread interrupted when dealing with request {}";
- private static final int MAX_SIZE = CONFIG.getQueryCacheSizeInMetric();
- private static final int DELETE_SIZE = 20;
-
- private static final List<SqlArgument> sqlArgumentList = new ArrayList<>(MAX_SIZE);
-
private long startTime = -1L;
Review comment:
```suggestion
```
Can the startTime be deleted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4547: [IOTDB-1969] Remove old metric framework from iotdb-server
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4547:
URL: https://github.com/apache/iotdb/pull/4547#discussion_r765561726
##########
File path: server/src/main/java/org/apache/iotdb/db/service/thrift/impl/TSServiceImpl.java
##########
@@ -170,21 +93,12 @@
private static final String INFO_INTERRUPT_ERROR =
"Current Thread interrupted when dealing with request {}";
- private static final int MAX_SIZE = CONFIG.getQueryCacheSizeInMetric();
- private static final int DELETE_SIZE = 20;
-
- private static final List<SqlArgument> sqlArgumentList = new ArrayList<>(MAX_SIZE);
-
private long startTime = -1L;
Review comment:
Ignore it :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] stormbroken commented on a change in pull request #4547: [IOTDB-1969] Remove old metric framework from iotdb-server
Posted by GitBox <gi...@apache.org>.
stormbroken commented on a change in pull request #4547:
URL: https://github.com/apache/iotdb/pull/4547#discussion_r765557811
##########
File path: site/src/main/.vuepress/config.js
##########
@@ -737,9 +737,8 @@ var config = {
['System-Tools/JMX-Tool','JMX Tool'],
['System-Tools/MLogParser-Tool','MLogParser Tool'],
['System-Tools/NodeTool','Node Tool'],
- ['System-Tools/Query-History-Visualization-Tool','Query History Visualization Tool'],
['System-Tools/Watermark-Tool','Watermark Tool'],
- ['System-Tools/Metric-Tool','Metric Tool']
+ ['System-Tools/Metric-Tool','Metric-Tool']
Review comment:
Ok, I will fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu merged pull request #4547: [IOTDB-1969] Remove old metric framework from iotdb-server
Posted by GitBox <gi...@apache.org>.
SteveYurongSu merged pull request #4547:
URL: https://github.com/apache/iotdb/pull/4547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] stormbroken commented on a change in pull request #4547: [IOTDB-1969] Remove old metric framework from iotdb-server
Posted by GitBox <gi...@apache.org>.
stormbroken commented on a change in pull request #4547:
URL: https://github.com/apache/iotdb/pull/4547#discussion_r765561166
##########
File path: server/src/main/java/org/apache/iotdb/db/service/thrift/impl/TSServiceImpl.java
##########
@@ -170,21 +93,12 @@
private static final String INFO_INTERRUPT_ERROR =
"Current Thread interrupted when dealing with request {}";
- private static final int MAX_SIZE = CONFIG.getQueryCacheSizeInMetric();
- private static final int DELETE_SIZE = 20;
-
- private static final List<SqlArgument> sqlArgumentList = new ArrayList<>(MAX_SIZE);
-
private long startTime = -1L;
Review comment:
This parameters may used by tracing, so I can delete this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4547: [IOTDB-1969] Remove old metric framework from iotdb-server
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4547:
URL: https://github.com/apache/iotdb/pull/4547#discussion_r765555322
##########
File path: site/src/main/.vuepress/config.js
##########
@@ -737,9 +737,8 @@ var config = {
['System-Tools/JMX-Tool','JMX Tool'],
['System-Tools/MLogParser-Tool','MLogParser Tool'],
['System-Tools/NodeTool','Node Tool'],
- ['System-Tools/Query-History-Visualization-Tool','Query History Visualization Tool'],
['System-Tools/Watermark-Tool','Watermark Tool'],
- ['System-Tools/Metric-Tool','Metric Tool']
+ ['System-Tools/Metric-Tool','Metric-Tool']
Review comment:
```suggestion
['System-Tools/Metric-Tool','Metric Tool']
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org