You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/06/23 21:56:39 UTC
[GitHub] [kafka] izzyacademy opened a new pull request #10924: KAFKA-8613: KIP-633 New APIs for Controlling Grace Period for Windowed Operations
izzyacademy opened a new pull request #10924:
URL: https://github.com/apache/kafka/pull/10924
KIP-633 New APIs for Controlling Grace Period for Windowed Operations
- Added API changes by KIP-633 for JoinWindows, SessionWindows, TimeWindows and SlidingWindows
- Renamed Windows.DEFAULT_GRACE_PERIOD_MS to DEPRECATED_OLD_24_HR_GRACE_PERIOD
- Added new constant Windows.NO_GRACE_PERIOD to avoid magic constants when 0 is specified as grace Period
- Added preliminary Java unit test cases for new API methods
- Replaced Deprecated calls with equivalent in Examples
- Replaced Deprecated API calls in Scala tests with updated API method calls
- Added Deprecation suppression in Tests for derecated API method calls in Java and Scala Tests
modified: streams/src/main/java/org/apache/kafka/streams/kstream/JoinWindows.java
modified: streams/src/main/java/org/apache/kafka/streams/kstream/SessionWindows.java
modified: streams/src/main/java/org/apache/kafka/streams/kstream/SlidingWindows.java
modified: streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindows.java
modified: streams/src/main/java/org/apache/kafka/streams/kstream/Windows.java
modified: streams/examples/src/main/java/org/apache/kafka/streams/examples/pageview/PageViewTypedDemo.java
modified: streams/examples/src/main/java/org/apache/kafka/streams/examples/pageview/PageViewUntypedDemo.java
modified: streams/examples/src/main/java/org/apache/kafka/streams/examples/temperature/TemperatureDemo.java
modified: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/KStream.scala
modified: streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/TopologyTest.scala
modified: streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/KStreamTest.scala
modified: streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/KTableTest.scala
modified: streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java
modified: streams/src/test/java/org/apache/kafka/streams/TopologyTest.java
modified: streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java
modified: streams/src/test/java/org/apache/kafka/streams/integration/InternalTopicIntegrationTest.java
modified: streams/src/test/java/org/apache/kafka/streams/integration/JoinStoreIntegrationTest.java
modified: streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationDedupIntegrationTest.java
modified: streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java
modified: streams/src/test/java/org/apache/kafka/streams/integration/KStreamRepartitionIntegrationTest.java
modified: streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java
modified: streams/src/test/java/org/apache/kafka/streams/integration/QueryableStateIntegrationTest.java
modified: streams/src/test/java/org/apache/kafka/streams/integration/RocksDBMetricsIntegrationTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/JoinWindowsTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/RepartitionTopicNamingTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/SessionWindowsTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/SlidingWindowsTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/TimeWindowsTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KGroupedStreamImplTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamLeftJoinTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamOuterJoinTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamRepartitionTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSessionWindowAggregateProcessorTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamWindowAggregateTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/SessionWindowedCogroupedKStreamImplTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/SessionWindowedKStreamImplTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedCogroupedKStreamImplTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImplTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/SuppressScenarioTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/SuppressTopologyTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/TimeWindowTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/TimeWindowedCogroupedKStreamImplTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/TimeWindowedKStreamImplTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/graph/GraphGraceSearchUtilTest.java
modified: streams/src/test/java/org/apache/kafka/streams/kstream/internals/graph/StreamsGraphTest.java
modified: streams/src/test/java/org/apache/kafka/streams/processor/internals/RepartitionOptimizingTest.java
modified: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java
modified: streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestClient.java
modified: streams/src/test/java/org/apache/kafka/streams/tests/StreamsOptimizedTest.java
modified: streams/src/test/java/org/apache/kafka/test/GenericInMemoryKeyValueStore.java
modified: streams/src/test/java/org/apache/kafka/test/GenericInMemoryTimestampedKeyValueStore.java
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] izzyacademy commented on pull request #10924: KAFKA-8613: KIP-633 New APIs for Controlling Grace Period for Windowed Operations
Posted by GitBox <gi...@apache.org>.
izzyacademy commented on pull request #10924:
URL: https://github.com/apache/kafka/pull/10924#issuecomment-867897115
I will close this one and resolve the conflicts before opening the next one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] izzyacademy closed pull request #10924: KAFKA-8613: KIP-633 New APIs for Controlling Grace Period for Windowed Operations
Posted by GitBox <gi...@apache.org>.
izzyacademy closed pull request #10924:
URL: https://github.com/apache/kafka/pull/10924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] izzyacademy commented on pull request #10924: KAFKA-8613: KIP-633 New APIs for Controlling Grace Period for Windowed Operations
Posted by GitBox <gi...@apache.org>.
izzyacademy commented on pull request #10924:
URL: https://github.com/apache/kafka/pull/10924#issuecomment-867188534
@ableegoldman @mjsax @showuon @cadonna
When you have a moment, please take a look.
This is an update based on the feedback from PR #10740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org