[jira] [Commented] (LANG-1228) IllegalAccessException swallowed in indexOfThrowable and indexOfType

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LANG-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15277564#comment-15277564 ] 

ASF GitHub Bot commented on LANG-1228:
--------------------------------------

GitHub user bdhess opened a pull request:

    https://github.com/apache/commons-lang/pull/139

    [LANG-1228] Prefer Throwable.getCause() in ExceptionUtils.getCause()

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bdhess/commons-lang get-cause

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #139
    
----
commit 2644ee0afc6fbc36f4f00990e4bffc55ca588f3f
Author: Bradley Hess <bd...@pobox.com>
Date:   2016-05-10T03:38:13Z

    [LANG-1228] Prefer Throwable.getCause() in ExceptionUtils.getCause()

----


> IllegalAccessException swallowed in indexOfThrowable and indexOfType
> --------------------------------------------------------------------
>
>                 Key: LANG-1228
>                 URL: https://issues.apache.org/jira/browse/LANG-1228
>             Project: Commons Lang
>          Issue Type: Bug
>            Reporter: Bradley Hess
>            Priority: Minor
>
> If {{ExceptionUtils.getCause}} is provided a throwable whose cause method cannot be interrogated by reflection due to an IllegalAccessError, the cause is not presented to the client.
> In principle this is to be expected from this legacy method.  However, {{indexOfThrowable}} and {{indexOfType}} rely on {{getCause}}, and are not marked as deprecated.
> Now that {{Throwable.getCause}} has been in the language for quite some time, I'd like to propose that, until {{ExceptionUtils.getCause}} is actually removed, that its behavior be modified to first attempt to get the exception cause using normal invocation, falling back to reflection if no cause is found.
> I'll be pushing a GitHub PR to this effect.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)