You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Thomas Graves (JIRA)" <ji...@apache.org> on 2011/06/13 17:21:51 UTC
[jira] [Created] (MAPREDUCE-2587) MR279: Fix RM version in the
cluster->about page
MR279: Fix RM version in the cluster->about page
-------------------------------------------------
Key: MAPREDUCE-2587
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2587
Project: Hadoop Map/Reduce
Issue Type: Bug
Reporter: Thomas Graves
Assignee: Thomas Graves
Priority: Minor
The Resource Manager version in the Cluster->About page always shows 1.0-SNAPSHOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2587) MR279: Fix RM version in the
cluster->about page
Posted by "Thomas Graves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049865#comment-13049865 ]
Thomas Graves commented on MAPREDUCE-2587:
------------------------------------------
Thanks. Sorry I misread jar as tar...
> MR279: Fix RM version in the cluster->about page
> -------------------------------------------------
>
> Key: MAPREDUCE-2587
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2587
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Thomas Graves
> Assignee: Thomas Graves
> Priority: Minor
> Attachments: MAPREDUCE-2587-279-v2.patch, MAPREDUCE-2587-279.patch
>
>
> The Resource Manager version in the Cluster->About page always shows 1.0-SNAPSHOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2587) MR279: Fix RM version in the
cluster->about page
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049875#comment-13049875 ]
Hadoop QA commented on MAPREDUCE-2587:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12482670/MAPREDUCE-2587-279-v2.patch
against trunk revision 1136000.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/396//console
This message is automatically generated.
> MR279: Fix RM version in the cluster->about page
> -------------------------------------------------
>
> Key: MAPREDUCE-2587
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2587
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Thomas Graves
> Assignee: Thomas Graves
> Priority: Minor
> Attachments: MAPREDUCE-2587-279-v2.patch, MAPREDUCE-2587-279.patch
>
>
> The Resource Manager version in the Cluster->About page always shows 1.0-SNAPSHOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2587) MR279: Fix RM version in the
cluster->about page
Posted by "Thomas Graves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049393#comment-13049393 ]
Thomas Graves commented on MAPREDUCE-2587:
------------------------------------------
Added YarnVersionInfo similar to common VersionInfo. Web page now display version similar to hadoop version:
ResourceManager version: 1.0-SNAPSHOT from 1134898 by tgraves source checksum 96be75aee888ed092bd922dddc8b0460
Hadoop version: 0.22.0-SNAPSHOT from 1134994 by tgraves source checksum 0f78ea668971fe51e7ebf4f97f84eed2
> MR279: Fix RM version in the cluster->about page
> -------------------------------------------------
>
> Key: MAPREDUCE-2587
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2587
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Thomas Graves
> Assignee: Thomas Graves
> Priority: Minor
> Attachments: MAPREDUCE-2587-279.patch
>
>
> The Resource Manager version in the Cluster->About page always shows 1.0-SNAPSHOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2587) MR279: Fix RM version in the
cluster->about page
Posted by "Thomas Graves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Graves updated MAPREDUCE-2587:
-------------------------------------
Status: Patch Available (was: Open)
> MR279: Fix RM version in the cluster->about page
> -------------------------------------------------
>
> Key: MAPREDUCE-2587
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2587
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Thomas Graves
> Assignee: Thomas Graves
> Priority: Minor
> Attachments: MAPREDUCE-2587-279.patch
>
>
> The Resource Manager version in the Cluster->About page always shows 1.0-SNAPSHOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2587) MR279: Fix RM version in the
cluster->about page
Posted by "Luke Lu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049851#comment-13049851 ]
Luke Lu commented on MAPREDUCE-2587:
------------------------------------
bq. uploaded v2 patch, moved saveVersion.sh to scripts dir but its still in the jar right now, let me know on that.
Thanks Tom! It's actually in the assembly tar ball but not in yarn-commmon-*.jar, which is what I meant.
+1, committed to MR-279 with the following mods:
# Changed assembly/all.xml to ensure file mode 0755 for scripts
# Wrapped long lines in TestYarnVersionInfo according to http://wiki.apache.org/hadoop/CodeReviewChecklist
> MR279: Fix RM version in the cluster->about page
> -------------------------------------------------
>
> Key: MAPREDUCE-2587
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2587
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Thomas Graves
> Assignee: Thomas Graves
> Priority: Minor
> Attachments: MAPREDUCE-2587-279-v2.patch, MAPREDUCE-2587-279.patch
>
>
> The Resource Manager version in the Cluster->About page always shows 1.0-SNAPSHOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2587) MR279: Fix RM version in the
cluster->about page
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated MAPREDUCE-2587:
-------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
> MR279: Fix RM version in the cluster->about page
> -------------------------------------------------
>
> Key: MAPREDUCE-2587
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2587
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Thomas Graves
> Assignee: Thomas Graves
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2587-279-v2.patch, MAPREDUCE-2587-279.patch
>
>
> The Resource Manager version in the Cluster->About page always shows 1.0-SNAPSHOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2587) MR279: Fix RM version in the
cluster->about page
Posted by "Luke Lu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049578#comment-13049578 ]
Luke Lu commented on MAPREDUCE-2587:
------------------------------------
lgtm overall. Some comment/question:
# saveVersion.sh probably should stay outside the resources as it'll get packaged in the jar.
# Have you test it under svn? It doesn't seem to work as is.
> MR279: Fix RM version in the cluster->about page
> -------------------------------------------------
>
> Key: MAPREDUCE-2587
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2587
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Thomas Graves
> Assignee: Thomas Graves
> Priority: Minor
> Attachments: MAPREDUCE-2587-279.patch
>
>
> The Resource Manager version in the Cluster->About page always shows 1.0-SNAPSHOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2587) MR279: Fix RM version in the
cluster->about page
Posted by "Thomas Graves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Graves updated MAPREDUCE-2587:
-------------------------------------
Attachment: MAPREDUCE-2587-279-v2.patch
> MR279: Fix RM version in the cluster->about page
> -------------------------------------------------
>
> Key: MAPREDUCE-2587
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2587
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Thomas Graves
> Assignee: Thomas Graves
> Priority: Minor
> Attachments: MAPREDUCE-2587-279-v2.patch, MAPREDUCE-2587-279.patch
>
>
> The Resource Manager version in the Cluster->About page always shows 1.0-SNAPSHOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2587) MR279: Fix RM version in the
cluster->about page
Posted by "Thomas Graves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049755#comment-13049755 ]
Thomas Graves commented on MAPREDUCE-2587:
------------------------------------------
Hey Luke, thanks for the review.
I'll move saveVersion.sh. What wasn't working for you? You do have to change permissions on saveVersion.sh to be executable. I tested in both git and svn and is working for me.
> MR279: Fix RM version in the cluster->about page
> -------------------------------------------------
>
> Key: MAPREDUCE-2587
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2587
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Thomas Graves
> Assignee: Thomas Graves
> Priority: Minor
> Attachments: MAPREDUCE-2587-279.patch
>
>
> The Resource Manager version in the Cluster->About page always shows 1.0-SNAPSHOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2587) MR279: Fix RM version in the
cluster->about page
Posted by "Thomas Graves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Graves updated MAPREDUCE-2587:
-------------------------------------
Attachment: MAPREDUCE-2587-279.patch
> MR279: Fix RM version in the cluster->about page
> -------------------------------------------------
>
> Key: MAPREDUCE-2587
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2587
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Thomas Graves
> Assignee: Thomas Graves
> Priority: Minor
> Attachments: MAPREDUCE-2587-279.patch
>
>
> The Resource Manager version in the Cluster->About page always shows 1.0-SNAPSHOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2587) MR279: Fix RM version in the
cluster->about page
Posted by "Thomas Graves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049776#comment-13049776 ]
Thomas Graves commented on MAPREDUCE-2587:
------------------------------------------
I see the saveVersion.sh in common is in the jar. Don't we want it to be in the jar so you could build from the source in the jar? I did also find an issue that you could only build from mapreduce top level directory so will fix that.
> MR279: Fix RM version in the cluster->about page
> -------------------------------------------------
>
> Key: MAPREDUCE-2587
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2587
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Thomas Graves
> Assignee: Thomas Graves
> Priority: Minor
> Attachments: MAPREDUCE-2587-279.patch
>
>
> The Resource Manager version in the Cluster->About page always shows 1.0-SNAPSHOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2587) MR279: Fix RM version in the
cluster->about page
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated MAPREDUCE-2587:
-------------------------------------
Fix Version/s: 0.23.0
Forgot to resolve this. This has been checked in.
> MR279: Fix RM version in the cluster->about page
> -------------------------------------------------
>
> Key: MAPREDUCE-2587
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2587
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Thomas Graves
> Assignee: Thomas Graves
> Priority: Minor
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2587-279-v2.patch, MAPREDUCE-2587-279.patch
>
>
> The Resource Manager version in the Cluster->About page always shows 1.0-SNAPSHOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2587) MR279: Fix RM version in the
cluster->about page
Posted by "Thomas Graves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049795#comment-13049795 ]
Thomas Graves commented on MAPREDUCE-2587:
------------------------------------------
uploaded v2 patch, moved saveVersion.sh to scripts dir but its still in the jar right now, let me know on that. Fixed so can build from directories other then top level mapreduce.
Note, that patch is applied to top level dir, you need to svn add the following:
mapreduce/yarn/yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestYarnVersionInfo.java
mapreduce/yarn/yarn-common/src/main/java/org/apache/hadoop/yarn/YarnVersionAnnotation.java
mapreduce/yarn/yarn-common/src/main/java/org/apache/hadoop/yarn/util/YarnVersionInfo.java
mapreduce/yarn/yarn-common/scripts/
mapreduce/yarn/yarn-common/scripts/saveVersion.sh also needs to be made executable
tested in git, svn, and build from source in jar. built from top level mapreduce, mapreduce/yarn, and mapreduce/yarn-common and it properly generated ./yarn/yarn-common/target/generated-sources/version/org/apache/hadoop/yarn/package-info.java in all cases.
Contents are like:
svn:
/*
* Generated by saveVersion.sh */
@YarnVersionAnnotation(version="1.0-SNAPSHOT", revision="1135920", branch="branches/MR-279/mapreduce/yarn",
user="tgraves", date="Wed Jun 15 14:14:44 UTC 2011", url="http://svn.apache.org/repos/asf/hadoop/common/branches/MR-279/mapreduce/yarn",
srcChecksum="174ef00f212ff0639b6bae4ac4f6c03e")
package org.apache.hadoop.yarn;
git:
/*
* Generated by saveVersion.sh
*/
@YarnVersionAnnotation(version="1.0-SNAPSHOT", revision="c9eb54b09d1a111c1efe9084dea6c0dbd97c7267", branch="origin/MR-279",
user="tgraves", date="Wed Jun 15 14:23:00 UTC 2011", url="git://host.com/home/tgraves/git/hadoop-common/mapreduce/yarn",
srcChecksum="174ef00f212ff0639b6bae4ac4f6c03e")
package org.apache.hadoop.yarn;
build jar:
/* * Generated by saveVersion.sh
*/
@YarnVersionAnnotation(version="1.0-SNAPSHOT", revision="Unknown", branch="Unknown",
user="tgraves", date="Wed Jun 15 14:28:29 UTC 2011", url="file:///home/tgraves/yarn/MR-279/mapreduce/target/tmp/hadoop-mapreduce-1.0-SNAPSHOT/sources/yarn",
srcChecksum="174ef00f212ff0639b6bae4ac4f6c03e")
package org.apache.hadoop.yarn;
> MR279: Fix RM version in the cluster->about page
> -------------------------------------------------
>
> Key: MAPREDUCE-2587
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2587
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Thomas Graves
> Assignee: Thomas Graves
> Priority: Minor
> Attachments: MAPREDUCE-2587-279-v2.patch, MAPREDUCE-2587-279.patch
>
>
> The Resource Manager version in the Cluster->About page always shows 1.0-SNAPSHOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2587) MR279: Fix RM version in the
cluster->about page
Posted by "Thomas Graves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048596#comment-13048596 ]
Thomas Graves commented on MAPREDUCE-2587:
------------------------------------------
The version is hardcoded in the code to 1.0-SNAPSHOT. Need to add generation of the yarn version info similar to how hadoop common does it.
> MR279: Fix RM version in the cluster->about page
> -------------------------------------------------
>
> Key: MAPREDUCE-2587
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2587
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Thomas Graves
> Assignee: Thomas Graves
> Priority: Minor
>
> The Resource Manager version in the Cluster->About page always shows 1.0-SNAPSHOT.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira