[GitHub] [couchdb] rnewson commented on a diff in pull request #4574: WIP remove Content-MD5 header support

["rnewson (via GitHub)" <gi...@apache.org>]

rnewson commented on code in PR #4574:
URL: https://github.com/apache/couchdb/pull/4574#discussion_r1185543644


##########
src/couch/test/eunit/couchdb_attachments_tests.erl:
##########
@@ -102,13 +102,7 @@ attachments_md5_tests() ->
             fun teardown/1,
             [
                 fun should_upload_attachment_without_md5/1,
-                fun should_upload_attachment_by_chunks_without_md5/1,
-                fun should_upload_attachment_with_valid_md5_header/1,
-                fun should_upload_attachment_by_chunks_with_valid_md5_header/1,
-                fun should_upload_attachment_by_chunks_with_valid_md5_trailer/1,
-                fun should_reject_attachment_with_invalid_md5/1,
-                fun should_reject_chunked_attachment_with_invalid_md5/1,
-                fun should_reject_chunked_attachment_with_invalid_md5_trailer/1

Review Comment:
   Good question. My view is that this PR (assuming it's right and complete) yields a CouchDB that completely ignores the Content-MD5 header, so it behaves identically whether the header is absent, present with the right value or present with the wrong value. Do we need tests for something that has no effect on CouchDB just because it did previously?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org