[GitHub] [incubator-nuttx-apps] no1wudi commented on a change in pull request #373: interpreters/duktape:Add duktape to global search path

[GitBox <gi...@apache.org>]

no1wudi commented on a change in pull request #373:
URL: https://github.com/apache/incubator-nuttx-apps/pull/373#discussion_r479657826



##########
File path: interpreters/duktape/Makefile
##########
@@ -48,23 +48,30 @@ CFLAGS += -I$(DUKTAPE_UNPACK)/extras/print-alert
 CFLAGS += -DDUK_CMDLINE_CONSOLE_SUPPORT
 CFLAGS += -DDUK_CMDLINE_PRINTALERT_SUPPORT
 
+APPINC = $(CURDIR)/$(DUKTAPE_UNPACK)
+
 $(DUKTAPE_TARBALL):
-	@echo "Downloading $(DUKTAPE_TARBALL)"
-	@wget $(DUKTAPE_URL)
+	$(Q) echo "Downloading $(DUKTAPE_TARBALL)"
+	$(Q) wget $(DUKTAPE_URL)
 
 $(DUKTAPE_UNPACK): $(DUKTAPE_TARBALL)
-	@echo "Unpacking $(DUKTAPE_TARBALL) to $(DUKTAPE_UNPACK)"
-	@tar xvfJ $(DUKTAPE_TARBALL)
-	@echo "Patching $(DUKTAPE_UNPACK)"
-	@patch -p0 < duk_cmdline.patch
-	@touch $(DUKTAPE_UNPACK)/.patch
+	$(Q) echo "Unpacking $(DUKTAPE_TARBALL) to $(DUKTAPE_UNPACK)"
+	$(Q) tar xvfJ $(DUKTAPE_TARBALL)
+	$(Q) mv duktape-$(DUKTAPE_VERSION) $(DUKTAPE_UNPACK)
+	$(Q) ln -sf $(APPINC)/src-noline/duktape.h $(APPINC)/duktape.h

Review comment:
       $(DUKTAPE_UNPACK) is a relative path, may cause some problem.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org