[jira] [Commented] (CLIMATE-483) Add non-rebinning version of PatternCorrelation metric

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLIMATE-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050017#comment-14050017 ] 

ASF GitHub Bot commented on CLIMATE-483:
----------------------------------------

GitHub user MJJoyce opened a pull request:

    https://github.com/apache/climate/pull/85

    CLIMATE-483 - Add basic PatternCorrelation metric

    - Rename old PatternCorrelation metric to TemporalPatternCorrelation
      since it does an annual reshaping of the datasets before doing a
      comparison and that isn't adequately reflected in the metric's name.
      The new name also falls in line with the functionality of the
      TemporalStdDevRatio metric which also does such a rebin.
    - Add basic PatternCorrelation metric that uses
      scipy.stats.mstats.linregress to return the r_value for the reference
      and target datasets. Note, the metric no longer returns a tuple of
      values. It now only returns the r_value. This falls much more in line
      with the metrics name in my opinion.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MJJoyce/climate CLIMATE-483

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/climate/pull/85.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #85
    
----
commit 73e05e3598a29ab29c11c830a04c20464c467020
Author: Michael Joyce <jo...@apache.org>
Date:   2014-07-02T15:10:40Z

    CLIMATE-483 - Add basic PatternCorrelation metric
    
    - Rename old PatternCorrelation metric to TemporalPatternCorrelation
      since it does an annual reshaping of the datasets before doing a
      comparison and that isn't adequately reflected in the metric's name.
      The new name also falls in line with the functionality of the
      TemporalStdDevRatio metric which also does such a rebin.
    - Add basic PatternCorrelation metric that uses
      scipy.stats.mstats.linregress to return the r_value for the reference
      and target datasets. Note, the metric no longer returns a tuple of
      values. It now only returns the r_value. This falls much more in line
      with the metrics name in my opinion.

----


> Add non-rebinning version of PatternCorrelation metric
> ------------------------------------------------------
>
>                 Key: CLIMATE-483
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-483
>             Project: Apache Open Climate Workbench
>          Issue Type: Sub-task
>          Components: metrics
>    Affects Versions: 0.3-incubating
>            Reporter: Michael Joyce
>            Assignee: Michael Joyce
>             Fix For: 0.4
>
>
> The current version of PatternCorrelation reshapes the data annually before calculations are run. We need a vesion that doesn't do this and we need to rename the current one to more correctly represent what it's actually doing.



--
This message was sent by Atlassian JIRA
(v6.2#6252)