You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/13 01:25:39 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #34577: [SPARK-37312][TESTS] Add `.java-version` to `.gitignore` and `.rat-excludes`
dongjoon-hyun opened a new pull request #34577:
URL: https://github.com/apache/spark/pull/34577
### What changes were proposed in this pull request?
To support Java 8/11/17 test more easily, this PR aims to add `.java-version` to `.gitignore` and `.rat-excludes`.
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34577: [SPARK-37312][TESTS] Add `.java-version` to `.gitignore` and `.rat-excludes`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34577:
URL: https://github.com/apache/spark/pull/34577#issuecomment-967761980
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49648/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34577: [SPARK-37312][TESTS] Add `.java-version` to `.gitignore` and `.rat-excludes`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34577:
URL: https://github.com/apache/spark/pull/34577#issuecomment-967788067
Thank you, @sarutak !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34577: [SPARK-37312][TESTS] Add `.java-version` to `.gitignore` and `.rat-excludes`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34577:
URL: https://github.com/apache/spark/pull/34577#issuecomment-967767066
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49648/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34577: [SPARK-37312][TESTS] Add `.java-version` to `.gitignore` and `.rat-excludes`
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34577:
URL: https://github.com/apache/spark/pull/34577#issuecomment-967786943
LGTM. Merging to `master`. Thank you @dongjoon-hyun !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34577: [SPARK-37312][TESTS] Add `.java-version` to `.gitignore` and `.rat-excludes`
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34577:
URL: https://github.com/apache/spark/pull/34577#issuecomment-967755244
**[Test build #145179 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145179/testReport)** for PR 34577 at commit [`6d0a9a4`](https://github.com/apache/spark/commit/6d0a9a4aee0f0256e921bc037a435f0e99148a78).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34577: [SPARK-37312][TESTS] Add `.java-version` to `.gitignore` and `.rat-excludes`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34577:
URL: https://github.com/apache/spark/pull/34577#issuecomment-967776695
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145179/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #34577: [SPARK-37312][TESTS] Add `.java-version` to `.gitignore` and `.rat-excludes`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #34577:
URL: https://github.com/apache/spark/pull/34577#issuecomment-967788067
Thank you, @viirya and @sarutak !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34577: [SPARK-37312][TESTS] Add `.java-version` to `.gitignore` and `.rat-excludes`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34577:
URL: https://github.com/apache/spark/pull/34577#issuecomment-967776464
**[Test build #145179 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145179/testReport)** for PR 34577 at commit [`6d0a9a4`](https://github.com/apache/spark/commit/6d0a9a4aee0f0256e921bc037a435f0e99148a78).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34577: [SPARK-37312][TESTS] Add `.java-version` to `.gitignore` and `.rat-excludes`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34577:
URL: https://github.com/apache/spark/pull/34577#issuecomment-967776695
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145179/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34577: [SPARK-37312][TESTS] Add `.java-version` to `.gitignore` and `.rat-excludes`
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34577:
URL: https://github.com/apache/spark/pull/34577#issuecomment-967755244
**[Test build #145179 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/145179/testReport)** for PR 34577 at commit [`6d0a9a4`](https://github.com/apache/spark/commit/6d0a9a4aee0f0256e921bc037a435f0e99148a78).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34577: [SPARK-37312][TESTS] Add `.java-version` to `.gitignore` and `.rat-excludes`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34577:
URL: https://github.com/apache/spark/pull/34577#issuecomment-967770093
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49648/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34577: [SPARK-37312][TESTS] Add `.java-version` to `.gitignore` and `.rat-excludes`
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34577:
URL: https://github.com/apache/spark/pull/34577#issuecomment-967770093
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49648/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak closed pull request #34577: [SPARK-37312][TESTS] Add `.java-version` to `.gitignore` and `.rat-excludes`
Posted by GitBox <gi...@apache.org>.
sarutak closed pull request #34577:
URL: https://github.com/apache/spark/pull/34577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org