[jira] [Commented] (AIRFLOW-1342) S3 connections use host "extra" parameter, not Host parameter on connection

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728084#comment-16728084 ] 

ASF GitHub Bot commented on AIRFLOW-1342:
-----------------------------------------

stale[bot] commented on pull request #2488: [AIRFLOW-1342] enable S3Hook to use host from connection
URL: https://github.com/apache/incubator-airflow/pull/2488
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> S3 connections use host "extra" parameter, not Host parameter on connection
> ---------------------------------------------------------------------------
>
>                 Key: AIRFLOW-1342
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-1342
>             Project: Apache Airflow
>          Issue Type: Bug
>    Affects Versions: 1.8.0, 1.8.1, 1.8.2
>            Reporter: Bryan Vanderhoof
>            Assignee: Victor Duarte Diniz Monteiro
>            Priority: Trivial
>
> The ability to connect to S3 using Sigv4 was added to resolve AIRFLOW-1034. That implementation expects a "host" parameter to be added to the JSON object in the Extra field on the connection object.
> However, the S3 connection object contains a top-level Host variable, which remains unused. This is deeply counterintuitive. The default should be to leverage this Host variable (and optionally the "host" parameter in the Extra object, to maintain compatibility with the existing implementation).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)