You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/03/22 08:56:55 UTC
[GitHub] [ignite] avplatonov commented on a change in pull request #6232:
IGNITE-11449: Vectorizer API for feature/label extracting
avplatonov commented on a change in pull request #6232: IGNITE-11449: Vectorizer API for feature/label extracting
URL: https://github.com/apache/ignite/pull/6232#discussion_r268081327
##########
File path: modules/ml/src/main/java/org/apache/ignite/ml/environment/logging/ConsoleLogger.java
##########
@@ -101,5 +102,14 @@ private Factory(VerboseLevel maxVerboseLevel) {
@Override public <T> MLLogger create(Class<T> targetCls) {
return new ConsoleLogger(maxVerboseLevel, targetCls.getName());
}
+
+ /** Low. */
+ public static IgniteFunction<Integer, MLLogger.Factory> LOW = part -> new Factory(VerboseLevel.LOW);
Review comment:
I'll add final keyword
And... RTFM: https://www.oracle.com/technetwork/articles/javaee/codeconventions-135099.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services