You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/04/14 19:01:33 UTC
Review Request 33175: RU: add compatible stacks for upgrade purposes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33175/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
Bugs: AMBARI-10472
https://issues.apache.org/jira/browse/AMBARI-10472
Repository: ambari
Description
-------
* Fixed code that was always assuming "current stack" operation. This includes distributing the bits.
* Added compatible stacks endpoint to show (duh) compatible stack versions in one request. This will be used exclusively to show all the versions a cluster may move to (say, HDP-2.2 to HDP-2.3). This will require UI work, filed separately.
* Added upgrade pack definitions that are copied from 2.2. We'll make changes as we get new runbook details.
* I could have spent another 3 days writing tests, so for now it's just for the compatibility checks and verification that all other tests continue to function properly. They'll get filled out as we move further into the cycle.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 07e70ab
ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinition.java 0b26308
ambari-server/src/main/java/org/apache/ambari/server/api/services/CompatibleRepositoryVersionService.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java dd7ec10
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java eb1a818
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java b656def
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java ada207a
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java e928e8e
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java 19c1aad
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 23c121e
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 787f5d6
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8e89cad
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b10f3f7
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java 88e62ff
ambari-server/src/test/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinitionTest.java 518b3cf
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7c2cdcd
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java 147dc49
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProviderTest.java PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml PRE-CREATION
Diff: https://reviews.apache.org/r/33175/diff/
Testing
-------
Manual API testing against a live cluster. Automated pending.
Thanks,
Nate Cole
Re: Review Request 33175: RU: add compatible stacks for upgrade
purposes
Posted by Nate Cole <nc...@hortonworks.com>.
> On April 14, 2015, 1:56 p.m., Tom Beerbower wrote:
> > Just so I understand the new compatible repository API... The endpoint looks something like this?
> >
> > /api/v1/stacks/HDP/versions/2.0/compatible_repository_version
> >
> > And that will return a set of repository versions that are compatible but belong to a different version under the same stack (and potentially a a different stack)?
Yes, exactly right. It was weird to create an HDP-2.3 repo version under HDP-2.2, so this endpoint will bridge the gap based on what upgrade packs are available.
> On April 14, 2015, 1:56 p.m., Tom Beerbower wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java, line 181
> > <https://reviews.apache.org/r/33175/diff/1/?file=927203#file927203line181>
> >
> > Where is this used?
This is what happens when you use some other code as basis. Will fix.
> On April 14, 2015, 1:56 p.m., Tom Beerbower wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java, line 241
> > <https://reviews.apache.org/r/33175/diff/1/?file=927203#file927203line241>
> >
> > I don't see a usage for this either.
See above.
> On April 14, 2015, 1:56 p.m., Tom Beerbower wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/CompatibleRepositoryVersionService.java, line 48
> > <https://reviews.apache.org/r/33175/diff/1/?file=927200#file927200line48>
> >
> > Param name doesn't match. Should be parentProperties?
Will fix.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33175/#review80061
-----------------------------------------------------------
On April 14, 2015, 1:32 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33175/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 1:32 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
>
>
> Bugs: AMBARI-10472
> https://issues.apache.org/jira/browse/AMBARI-10472
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Fixed code that was always assuming "current stack" operation. This includes distributing the bits.
> * Added compatible stacks endpoint to show (duh) compatible stack versions in one request. This will be used exclusively to show all the versions a cluster may move to (say, HDP-2.2 to HDP-2.3). This will require UI work, filed separately.
> * Added upgrade pack definitions that are copied from 2.2. We'll make changes as we get new runbook details.
> * I could have spent another 3 days writing tests, so for now it's just for the compatibility checks and verification that all other tests continue to function properly. They'll get filled out as we move further into the cycle.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 07e70ab
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinition.java 0b26308
> ambari-server/src/main/java/org/apache/ambari/server/api/services/CompatibleRepositoryVersionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java dd7ec10
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java eb1a818
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java b656def
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java ada207a
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java e928e8e
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java 19c1aad
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 23c121e
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 787f5d6
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8e89cad
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b10f3f7
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java 88e62ff
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinitionTest.java 518b3cf
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7c2cdcd
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java 147dc49
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33175/diff/
>
>
> Testing
> -------
>
> Manual API testing against a live cluster.
>
> Automated:
> Tests run: 2854, Failures: 0, Errors: 0, Skipped: 16
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:44.208s
> [INFO] Finished at: Tue Apr 14 13:17:17 EDT 2015
> [INFO] Final Memory: 41M/686M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 33175: RU: add compatible stacks for upgrade
purposes
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33175/#review80061
-----------------------------------------------------------
Just so I understand the new compatible repository API... The endpoint looks something like this?
/api/v1/stacks/HDP/versions/2.0/compatible_repository_version
And that will return a set of repository versions that are compatible but belong to a different version under the same stack (and potentially a a different stack)?
ambari-server/src/main/java/org/apache/ambari/server/api/services/CompatibleRepositoryVersionService.java
<https://reviews.apache.org/r/33175/#comment129829>
Param name doesn't match. Should be parentProperties?
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java
<https://reviews.apache.org/r/33175/#comment129826>
Where is this used?
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java
<https://reviews.apache.org/r/33175/#comment129827>
I don't see a usage for this either.
- Tom Beerbower
On April 14, 2015, 5:32 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33175/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 5:32 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
>
>
> Bugs: AMBARI-10472
> https://issues.apache.org/jira/browse/AMBARI-10472
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Fixed code that was always assuming "current stack" operation. This includes distributing the bits.
> * Added compatible stacks endpoint to show (duh) compatible stack versions in one request. This will be used exclusively to show all the versions a cluster may move to (say, HDP-2.2 to HDP-2.3). This will require UI work, filed separately.
> * Added upgrade pack definitions that are copied from 2.2. We'll make changes as we get new runbook details.
> * I could have spent another 3 days writing tests, so for now it's just for the compatibility checks and verification that all other tests continue to function properly. They'll get filled out as we move further into the cycle.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 07e70ab
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinition.java 0b26308
> ambari-server/src/main/java/org/apache/ambari/server/api/services/CompatibleRepositoryVersionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java dd7ec10
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java eb1a818
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java b656def
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java ada207a
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java e928e8e
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java 19c1aad
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 23c121e
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 787f5d6
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8e89cad
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b10f3f7
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java 88e62ff
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinitionTest.java 518b3cf
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7c2cdcd
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java 147dc49
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33175/diff/
>
>
> Testing
> -------
>
> Manual API testing against a live cluster.
>
> Automated:
> Tests run: 2854, Failures: 0, Errors: 0, Skipped: 16
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:44.208s
> [INFO] Finished at: Tue Apr 14 13:17:17 EDT 2015
> [INFO] Final Memory: 41M/686M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 33175: RU: add compatible stacks for upgrade
purposes
Posted by Nate Cole <nc...@hortonworks.com>.
> On April 14, 2015, 2:04 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java, line 199
> > <https://reviews.apache.org/r/33175/diff/1/?file=927203#file927203line199>
> >
> > We should make HDP-UTILS a static constant.
Will be removed when the unused function is removed (thanks Tom!).
> On April 14, 2015, 2:04 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml, line 22
> > <https://reviews.apache.org/r/33175/diff/1/?file=927212#file927212line22>
> >
> > Is it nearly identical to upgrade-2.2 with the exception of this line?
Correct. This was just copied (for now) and we'll modify as needed for 2.3. (Hive backup message, other specialty things as needed, etc etc)
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33175/#review80068
-----------------------------------------------------------
On April 14, 2015, 2:21 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33175/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 2:21 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
>
>
> Bugs: AMBARI-10472
> https://issues.apache.org/jira/browse/AMBARI-10472
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Fixed code that was always assuming "current stack" operation. This includes distributing the bits.
> * Added compatible stacks endpoint to show (duh) compatible stack versions in one request. This will be used exclusively to show all the versions a cluster may move to (say, HDP-2.2 to HDP-2.3). This will require UI work, filed separately.
> * Added upgrade pack definitions that are copied from 2.2. We'll make changes as we get new runbook details.
> * I could have spent another 3 days writing tests, so for now it's just for the compatibility checks and verification that all other tests continue to function properly. They'll get filled out as we move further into the cycle.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 07e70ab
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinition.java 0b26308
> ambari-server/src/main/java/org/apache/ambari/server/api/services/CompatibleRepositoryVersionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java dd7ec10
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java eb1a818
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java b656def
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java ada207a
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java e928e8e
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java 19c1aad
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 23c121e
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 787f5d6
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8e89cad
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b10f3f7
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java 88e62ff
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinitionTest.java 518b3cf
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7c2cdcd
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java 147dc49
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33175/diff/
>
>
> Testing
> -------
>
> Manual API testing against a live cluster.
>
> Automated:
> Tests run: 2854, Failures: 0, Errors: 0, Skipped: 16
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:44.208s
> [INFO] Finished at: Tue Apr 14 13:17:17 EDT 2015
> [INFO] Final Memory: 41M/686M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 33175: RU: add compatible stacks for upgrade
purposes
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33175/#review80068
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java
<https://reviews.apache.org/r/33175/#comment129831>
Nice, we support both loookups.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java
<https://reviews.apache.org/r/33175/#comment129832>
We should make HDP-UTILS a static constant.
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
<https://reviews.apache.org/r/33175/#comment129833>
This should make it easier to call this function.
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml
<https://reviews.apache.org/r/33175/#comment129834>
Is it nearly identical to upgrade-2.2 with the exception of this line?
- Alejandro Fernandez
On April 14, 2015, 5:32 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33175/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 5:32 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
>
>
> Bugs: AMBARI-10472
> https://issues.apache.org/jira/browse/AMBARI-10472
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Fixed code that was always assuming "current stack" operation. This includes distributing the bits.
> * Added compatible stacks endpoint to show (duh) compatible stack versions in one request. This will be used exclusively to show all the versions a cluster may move to (say, HDP-2.2 to HDP-2.3). This will require UI work, filed separately.
> * Added upgrade pack definitions that are copied from 2.2. We'll make changes as we get new runbook details.
> * I could have spent another 3 days writing tests, so for now it's just for the compatibility checks and verification that all other tests continue to function properly. They'll get filled out as we move further into the cycle.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 07e70ab
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinition.java 0b26308
> ambari-server/src/main/java/org/apache/ambari/server/api/services/CompatibleRepositoryVersionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java dd7ec10
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java eb1a818
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java b656def
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java ada207a
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java e928e8e
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java 19c1aad
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 23c121e
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 787f5d6
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8e89cad
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b10f3f7
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java 88e62ff
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinitionTest.java 518b3cf
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7c2cdcd
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java 147dc49
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33175/diff/
>
>
> Testing
> -------
>
> Manual API testing against a live cluster.
>
> Automated:
> Tests run: 2854, Failures: 0, Errors: 0, Skipped: 16
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:44.208s
> [INFO] Finished at: Tue Apr 14 13:17:17 EDT 2015
> [INFO] Final Memory: 41M/686M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 33175: RU: add compatible stacks for upgrade
purposes
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33175/#review80074
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On April 14, 2015, 6:21 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33175/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 6:21 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
>
>
> Bugs: AMBARI-10472
> https://issues.apache.org/jira/browse/AMBARI-10472
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Fixed code that was always assuming "current stack" operation. This includes distributing the bits.
> * Added compatible stacks endpoint to show (duh) compatible stack versions in one request. This will be used exclusively to show all the versions a cluster may move to (say, HDP-2.2 to HDP-2.3). This will require UI work, filed separately.
> * Added upgrade pack definitions that are copied from 2.2. We'll make changes as we get new runbook details.
> * I could have spent another 3 days writing tests, so for now it's just for the compatibility checks and verification that all other tests continue to function properly. They'll get filled out as we move further into the cycle.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 07e70ab
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinition.java 0b26308
> ambari-server/src/main/java/org/apache/ambari/server/api/services/CompatibleRepositoryVersionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java dd7ec10
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java eb1a818
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java b656def
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java ada207a
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java e928e8e
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java 19c1aad
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 23c121e
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 787f5d6
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8e89cad
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b10f3f7
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java 88e62ff
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinitionTest.java 518b3cf
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7c2cdcd
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java 147dc49
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33175/diff/
>
>
> Testing
> -------
>
> Manual API testing against a live cluster.
>
> Automated:
> Tests run: 2854, Failures: 0, Errors: 0, Skipped: 16
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:44.208s
> [INFO] Finished at: Tue Apr 14 13:17:17 EDT 2015
> [INFO] Final Memory: 41M/686M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 33175: RU: add compatible stacks for upgrade
purposes
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33175/#review80078
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On April 14, 2015, 2:21 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33175/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 2:21 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
>
>
> Bugs: AMBARI-10472
> https://issues.apache.org/jira/browse/AMBARI-10472
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Fixed code that was always assuming "current stack" operation. This includes distributing the bits.
> * Added compatible stacks endpoint to show (duh) compatible stack versions in one request. This will be used exclusively to show all the versions a cluster may move to (say, HDP-2.2 to HDP-2.3). This will require UI work, filed separately.
> * Added upgrade pack definitions that are copied from 2.2. We'll make changes as we get new runbook details.
> * I could have spent another 3 days writing tests, so for now it's just for the compatibility checks and verification that all other tests continue to function properly. They'll get filled out as we move further into the cycle.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 07e70ab
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinition.java 0b26308
> ambari-server/src/main/java/org/apache/ambari/server/api/services/CompatibleRepositoryVersionService.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java dd7ec10
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java eb1a818
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java b656def
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java ada207a
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java e928e8e
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java 19c1aad
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 23c121e
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 787f5d6
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8e89cad
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b10f3f7
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml PRE-CREATION
> ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java 88e62ff
> ambari-server/src/test/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinitionTest.java 518b3cf
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7c2cdcd
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java 147dc49
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProviderTest.java PRE-CREATION
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33175/diff/
>
>
> Testing
> -------
>
> Manual API testing against a live cluster.
>
> Automated:
> Tests run: 2854, Failures: 0, Errors: 0, Skipped: 16
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 21:44.208s
> [INFO] Finished at: Tue Apr 14 13:17:17 EDT 2015
> [INFO] Final Memory: 41M/686M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 33175: RU: add compatible stacks for upgrade
purposes
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33175/
-----------------------------------------------------------
(Updated April 14, 2015, 2:21 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
Bugs: AMBARI-10472
https://issues.apache.org/jira/browse/AMBARI-10472
Repository: ambari
Description
-------
* Fixed code that was always assuming "current stack" operation. This includes distributing the bits.
* Added compatible stacks endpoint to show (duh) compatible stack versions in one request. This will be used exclusively to show all the versions a cluster may move to (say, HDP-2.2 to HDP-2.3). This will require UI work, filed separately.
* Added upgrade pack definitions that are copied from 2.2. We'll make changes as we get new runbook details.
* I could have spent another 3 days writing tests, so for now it's just for the compatibility checks and verification that all other tests continue to function properly. They'll get filled out as we move further into the cycle.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 07e70ab
ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinition.java 0b26308
ambari-server/src/main/java/org/apache/ambari/server/api/services/CompatibleRepositoryVersionService.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java dd7ec10
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java eb1a818
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java b656def
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java ada207a
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java e928e8e
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java 19c1aad
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 23c121e
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 787f5d6
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8e89cad
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b10f3f7
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java 88e62ff
ambari-server/src/test/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinitionTest.java 518b3cf
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7c2cdcd
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java 147dc49
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProviderTest.java PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml PRE-CREATION
Diff: https://reviews.apache.org/r/33175/diff/
Testing
-------
Manual API testing against a live cluster.
Automated:
Tests run: 2854, Failures: 0, Errors: 0, Skipped: 16
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:44.208s
[INFO] Finished at: Tue Apr 14 13:17:17 EDT 2015
[INFO] Final Memory: 41M/686M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 33175: RU: add compatible stacks for upgrade
purposes
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33175/
-----------------------------------------------------------
(Updated April 14, 2015, 1:32 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Tom Beerbower.
Bugs: AMBARI-10472
https://issues.apache.org/jira/browse/AMBARI-10472
Repository: ambari
Description
-------
* Fixed code that was always assuming "current stack" operation. This includes distributing the bits.
* Added compatible stacks endpoint to show (duh) compatible stack versions in one request. This will be used exclusively to show all the versions a cluster may move to (say, HDP-2.2 to HDP-2.3). This will require UI work, filed separately.
* Added upgrade pack definitions that are copied from 2.2. We'll make changes as we get new runbook details.
* I could have spent another 3 days writing tests, so for now it's just for the compatibility checks and verification that all other tests continue to function properly. They'll get filled out as we move further into the cycle.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java 07e70ab
ambari-server/src/main/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinition.java 0b26308
ambari-server/src/main/java/org/apache/ambari/server/api/services/CompatibleRepositoryVersionService.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java dd7ec10
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java eb1a818
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProvider.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/OperatingSystemResourceProvider.java b656def
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java ada207a
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java e928e8e
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/DistributeRepositoriesActionListener.java 19c1aad
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 23c121e
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 787f5d6
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 8e89cad
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java b10f3f7
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/query/QueryImplTest.java 88e62ff
ambari-server/src/test/java/org/apache/ambari/server/api/resources/StackVersionResourceDefinitionTest.java 518b3cf
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 7c2cdcd
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java 147dc49
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CompatibleRepositoryVersionResourceProviderTest.java PRE-CREATION
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_to_new_stack.xml PRE-CREATION
Diff: https://reviews.apache.org/r/33175/diff/
Testing (updated)
-------
Manual API testing against a live cluster.
Automated:
Tests run: 2854, Failures: 0, Errors: 0, Skipped: 16
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:44.208s
[INFO] Finished at: Tue Apr 14 13:17:17 EDT 2015
[INFO] Final Memory: 41M/686M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole