You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/27 22:27:08 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #33545: [SPARK-36319][SQL][PySpark] Have Observation return Map instead of Row
HyukjinKwon commented on a change in pull request #33545:
URL: https://github.com/apache/spark/pull/33545#discussion_r677842548
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Observation.scala
##########
@@ -82,7 +86,7 @@ class Observation(name: String) {
* @throws InterruptedException interrupted while waiting
*/
@throws[InterruptedException]
- def get: Row = {
+ def getAsRow: Row = {
Review comment:
Can we just change the return type alone instead of adding other new methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org